Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Icons block label is using WP-Admin styles for text #46778

Closed
bgardner opened this issue Dec 24, 2022 · 3 comments · Fixed by #67204
Closed

Social Icons block label is using WP-Admin styles for text #46778

bgardner opened this issue Dec 24, 2022 · 3 comments · Fixed by #67204
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts CSS Styling Related to editor and front end styles, CSS-specific issues. [Type] Bug An existing feature does not function as intended

Comments

@bgardner
Copy link

Description

When the Social Icons block is being used with Link settings > Show labels option enabled, the WP-Admin styles are kicking in for the text in the editor. (Front end is using the theme font, while back end is using system font).

Step-by-step reproduction instructions

  1. Add Social Icons
  2. Enable Link settings > Show labels option
  3. See system fonts loaded from the following CSS:
.edit-post-visual-editor .components-button {
    font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Roboto,Oxygen-Sans,Ubuntu,Cantarell,Helvetica Neue,sans-serif;
    font-size: 13px;
    padding: 6px 12px;
}

Screenshots, screen recording, code snippet

image

Environment info

WordPress 6.1.1, Gutenberg 14.8

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added the [Block] Social Affects the Social Block - used to display Social Media accounts label Dec 24, 2022
@skorasaurus skorasaurus added the CSS Styling Related to editor and front end styles, CSS-specific issues. label Dec 26, 2022
@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Jul 27, 2023
@jordesign
Copy link
Contributor

Confirmed this in testing - still present in WP 6.2.2

@bgardner
Copy link
Author

bgardner commented Jan 8, 2024

Any updates on this? Seems like a relatively light fix, no?

@himanshupathak95
Copy link
Contributor

Hey @bgardner, Thanks for reporting this.

I can confirm that the Social Icons block label styling issue reported in WordPress 6.1.1 and Gutenberg 14.8 continues to persist in the latest WordPress 6.8 and Gutenberg 19.7 versions.

Social Icons block labels use WP-Admin system fonts in the editor when "Show labels" is enabled, overriding theme typography.

Screenshots

Image
Image

As you correctly mentioned, the fix must be relatively light and simple.

I would like to take a swing at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts CSS Styling Related to editor and front end styles, CSS-specific issues. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants