-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List Block: A couple of writing flow issues #48670
Comments
Tab and shift+tab don't indent or unindent - #45404 |
Related to this, I run into unexpected behavior when selecting list items using the keyboard. Here I'll share a video to demonstrate. In short, when selecting list item text using keyboard navigation, I run into two issues:
This was tested on Chrome 109.0.5414.119 list-selection.mp4 |
It seems like the second point is being addressed by #44727. |
The List block is different to the Paragraph block as it has no parent block. The list block is currently behaving like other blocks that have a parent block, eg. the Quote block also selects the parent block first when navigating with the arrow keys. If the List block was to be changed so that navigation with the arrow jumped the cursor straight to the first child, and when going up straight to the previous block, then how would we provide for easy selection of the parent block via the keyboard? |
👍 I'll update the issue to note this. |
This one I can't reproduce (tried FF and Chrome). Focus remains on the list item 🤔 |
I found an easier way to reproduce, and to clarify, perhaps focus isn't actually lost (or perhaps the issue I was seeing has been fixed?), the caret is still where it needs to be, I can still type. But the block toolbar loses its place, so perhaps focus is lost momentarily? Not sure what's going on. But try this:
GIF showing this: |
@jasmussen I'm not sure what is happening here. The element (or virtual element rather) is correctly being passed down to |
In any case, the other issues are fixed, so may be good to rename this issue or open a new one. |
Merging lists into one was a big one, that's fixed 🎉 Tab and shift tab to indent/unindent when focus is in a list item is tracked separately, that was the other big one (and remains IMO a high priority). But I'm always in favor of closing, especially as it's so easy to reopen. Since focus doesn't seem to be lost in the last case, I'm happy to close this one. It'd be nice to figure out what's going on with the block toolbar, but we can see how this goes. |
The list block has come a long way, and is largely working very well. But for some of the intricate writing flow behaviors, there are some rough edges that I've tried to capture here. Some are most likely discussed/tracked elsewhere, but sharing them here as context for the holistic experience.
The basic interaction works well:
But there are some unexpected behaviors.
Tab and shift+tab don't indent or unindent
I'm aware of the tab for moving into the inspector, but I'm curious what we can do to explore changes here, whether a non default preferences setting or some other shortcuts that can tailor your use case.
Making a partial selection across two list items, and pressing "Enter" doesn't do anything
In this GIF, after making this partial selection I'm pressing the Enter key on the keyboard:
I would expect it to delete the partial selection and make a new empty list item between the two.
Focus is lost when splitting nested list items
Make a list with two nesting levels. Set the caret inside the 2nd nesting level, press Enter twice. The block toolbar is now in the top left corner of the screen, and focus on the main iframe, removed from the list block:
Merging nested lists do not merge the list blocks
In the following list item set up:
Select all the text on
Top level #2
and press backspace. I would expect this action to merge the two nested lists into a single list, like so:Visually this appears to be the case, but in fact there are now two nested list blocks, like so:
GIF showing the same:
Intentional behaviors, collapsed for clarity
Pressing the down arrow from a paragraph and into a list makes you select the list itself, not the first list item
Since this is not the case when moving between two paragraphs, this is unexpected:
I would instead expect the caret to be inside the first list item, just as it is when arrowing between paragraphs.
Similarly, pressing the up-arrow to navigate from a paragraph through all list items and into another paragraph above stops at the first list item, before it selects the whole list block.
The text was updated successfully, but these errors were encountered: