Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browse mode > Navigation: odd experience with adding and removing submenu links #48741

Closed
annezazu opened this issue Mar 3, 2023 · 6 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Mar 3, 2023

Using 6.2-beta 4, I noticed some strangeness where if I add a custom link or page link block, since I can't select or customize the location of those, I'm able to click on them. From there, if I click the + button, it adds a submenu item. If I click on a properly added page link block, it takes me to that page and I'm unable to add a submenu item directly using the + sign (have to use three dot). This entire experience feels janky. I couldn't figure out at first why a submenu was being created until I realized that it was because I could select the empty page link block in a way I couldn't with the others. Tied to this, if you delete a custom link within a submenu, the submenu as an entity isn't removed and remains:

sub.menu.nav.block.mov

To summarize, three issues:

  • If you select a not yet set up page link block and click the +, it adds as a submenu.
  • When you click the + while selecting a not setup block, the interface for the inserter is different (no ability to search).
  • If you remove a submenu item, the submenu section remains.

cc @WordPress/gutenberg-design as I'm not sure what's intended here.

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Mar 3, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Mar 5, 2023
@SaxonF
Copy link
Contributor

SaxonF commented Mar 6, 2023

Agree this shouldn't occur as its quite unpredictable. Add block should just add menu items at root level regardless of selection.

@jasmussen
Copy link
Contributor

Agreed, this is rough in the general navigation block as well.

@jameskoster
Copy link
Contributor

If you select a not yet set up page link block and click the +, it adds as a submenu.
When you click the + while selecting a not setup block, the interface for the inserter is different (no ability to search).

These two should be fixed by #48746.

It's a bit awkward that you can add a 'submenu' but not also add a label for that item without going into the full screen editor. I can't really see a quick solution for that in terms of 6.2, except for removing 'Submenu' as an option in the Inserter in the Navigation panel.

@ndiego ndiego moved this from ❓ Triage to 🗣️ In discussion, needs decision in WordPress 6.2 Editor Tasks Mar 8, 2023
@ndiego ndiego moved this from 🗣️ In discussion, needs decision to 🐛 Punted to 6.2.1 in WordPress 6.2 Editor Tasks Mar 9, 2023
@annezazu annezazu moved this to ❓ Triage in WordPress 6.2.x Editor Tasks Apr 10, 2023
@Mamaduka
Copy link
Member

The Navigation panel path has been removed from 6.2. Punting this to 6.3.

@Mamaduka Mamaduka moved this from 🐛 Punted to 6.2.1 to 🦵 Punted to 6.3 in WordPress 6.2 Editor Tasks Apr 13, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.3.x Editor Tasks May 23, 2023
@ndiego
Copy link
Member

ndiego commented Jun 26, 2023

@annezazu I think this now can be closed due to all the updates to the Navigation panel in the Site Editor.

@annezazu
Copy link
Contributor Author

Agreed. Here's a quick visual of what the experience is like currently where the ability to add is removed as of 16.1 RC1:

Screen.Recording.2023-06-26.at.8.37.44.AM.mov

@github-project-automation github-project-automation bot moved this from ❓ Triage to ✅ Done in WordPress 6.3.x Editor Tasks Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

6 participants