Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting multiple blocks from list view #49087

Closed
SaxonF opened this issue Mar 15, 2023 · 6 comments · Fixed by #50422
Closed

Deleting multiple blocks from list view #49087

SaxonF opened this issue Mar 15, 2023 · 6 comments · Fixed by #50422
Assignees
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.

Comments

@SaxonF
Copy link
Contributor

SaxonF commented Mar 15, 2023

What problem does this address?

When selecting multiple blocks from within the list view in the site editor and hitting delete, it doesn't delete those blocks.

image

Another block deleting issue I've run into is that the delete actions seems to only work in certain scenarios. The video below shows selecting a paragraph block below the post content block and hitting delete just selects post content block instead.

delete-blocks.mp4

It might be worth looking at both issues to see if there is a singular solution.

What is your proposed solution?

Selecting a block from list view and hitting delete should always delete the selected block.

@SaxonF SaxonF added the [Feature] List View Menu item in the top toolbar to select blocks from a list of links. label Mar 15, 2023
@Thelmachido
Copy link

Thelmachido commented Mar 17, 2023

I am getting the same issue, hitting the Delete button on the keyboard doesn't work - the blocks can be removed using more option.

However, when Gutenberg is deactivated the issue goes away. Additionally, this is only happening when my site is using the TT3 theme when I switch to TT1 everything works as expected.

Screenshot 2023-03-17 at 14 03 50

WordPress 6.1.1
Gutenberg 15.3.1

@Thelmachido
Copy link

I'm now able to delete the block using the keyboard delete option @SaxonF please check your site and confirm.

@jasmussen
Copy link
Contributor

For what it's worth, the Delete key still doesn't work for me testing trunk this morning:

delete

In the middle of that GIF I'm selecting a bunch of blocks in the list view using Shift + select, then pressing the Delete key, but nothing happening.

@annezazu annezazu added this to Polish May 1, 2023
@annezazu annezazu moved this to Needs development in Polish May 1, 2023
@kevin940726
Copy link
Member

I'm able to reproduce this bug, but I'm not sure which commit broke it (if it used to work before).

However, I noticed that sometimes clicking/selecting blocks in the list view doesn't focus the elements, but instead moves focus to the canvas. I think this is unexpected and could be considered a bug accessibility-wise. My guess is, ironically, this behavior was probably what made pressing "delete" work in the list view before 😅. Maybe some PRs fixed a part of this bug and "broke" this behavior? Just my guess 😆.

If no one is working on this, I can give it a try next!

@kevin940726 kevin940726 self-assigned this May 3, 2023
@talldan
Copy link
Contributor

talldan commented May 5, 2023

I'm able to reproduce this bug, but I'm not sure which commit broke it (if it used to work before).

I think the way it worked before was to always transfer focus to the canvas and use the multi-select and delete shortcut features in the canvas.

I don't think there's ever been a shortcut for deleting blocks in List View, but i'd be cool to have.

@talldan talldan added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels May 5, 2023
@andrewserong
Copy link
Contributor

andrewserong commented May 5, 2023

I don't think there's ever been a shortcut for deleting blocks in List View, but i'd be cool to have.

That's my understanding, too. For a fair few of what folks perceive as bugs with keyboard behaviour in the list view, it's more that there are features that haven't been written yet. Definitely fair to think of them as UX bugs, but the Enhancement label feels appropriate to me here, too.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 8, 2023
@priethor priethor moved this from Needs development to In progress in Polish May 8, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 31, 2023
@priethor priethor moved this from In progress to Done in Polish May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants