Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent focus loss when selecting around the end of the last text block #4915

Closed
jasmussen opened this issue Feb 7, 2018 · 3 comments
Closed
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...

Comments

@jasmussen
Copy link
Contributor

We allow a user to hold shift and select text inside a paragraph block. When the user starts to select text around the end of a paragraph, the down and right arrows can cause a focus loss (focus is set on body).

Use case 1, pressing shift down in the last text block:

  • Have only a single paragraph block on the page and set the caret on the last line
  • Hold shift and press down to select downwards, and note how focus is lost

pressing shift down at the end of a textblock

Use case 2, pressing shift rigth in the last text block:

  • Have only a single paragraph block on the page and set the caret on the last line
  • Hold shift and select text leftwards. Now press the right arrow because you want to select less text, but notice instead how the focus is lost.

selecting text at the end loses focus

In both cases, cross-block keyboard selection ideally shouldn't fire, neither when there's just one block on the page, nor when that block is the last block and you're selecting downwards.

@jasmussen jasmussen added [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Feature] Block Multi Selection The ability to select and manipulate multiple blocks labels Feb 7, 2018
@jasmussen
Copy link
Contributor Author

Somewhat related, #3745 (comment):

Multi-selection shift expanding behavior differs from master, where shift-selecting upwards multiple times and then shift-selecting downward will reverse the selection direction from the originating block.

@bph
Copy link
Contributor

bph commented Feb 14, 2018

I encountered a similar issue with Safari - putting the cursor at the end of the block and then use backspace to remove characters.
It removes not the next character but the second last character. And when I tried to type from the position, the cursor would not move .
http://recordit.co/RnP1d6E2MS

@youknowriad
Copy link
Contributor

youknowriad commented Nov 26, 2018

Unless, I'm missing something this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Multi Selection The ability to select and manipulate multiple blocks [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Projects
None yet
Development

No branches or pull requests

3 participants