Toolbar Shortcut (alt + F10) to focus block toolbar from empty block

[jeryj]

I think the behavior of the toolbar shortcut would be more consistent if it moved focus into the block toolbar from an empty block in the default view.

For example, here's a table of the current behavior for alt + F10 (fn + option + F10 on smaller mac keyboard) shortcut in different contexts:

View	Is Unmodified Default Block (empty)	Toolbar Focused from Shortcut
Unified/Top Toolbar	No (has content)	Block Toolbar
Unified/Top Toolbar	Yes (empty block)	Block Toolbar
Default	No (has content)	Block Toolbar
Default	Yes (empty block)	Document Toolbar

If we move focus into the block toolbar from the empty default block, I think it would be more a consistent behavior across all views.

Testing instructions

1. View: Top Toolbar, Block with content

• Turn on Top Toolbar view from Options menu
• Move focus to block with content
• Press alt + F10
• Focus is in the Block Toolbar

2. View: Top Toolbar, Empty Block

• Turn on Top Toolbar view from Options menu
• Move focus to empty/new block
• Press alt + F10
• Focus is in the Block Toolbar

3. View: Default, Block with Content

• Turn off Top Toolbar view from Options menu
• Move focus to block with content
• Press alt + F10
• Focus is in the Block Toolbar

4. View: Default, Empty Block

• Turn off Top Toolbar view from Options menu
• Move focus to empty/new block
• Press alt + F10
• Focus is in the Document Toolbar (I propose we move focus to block toolbar instead)

Video of Behavior

Screen.Recording.2023-04-12.at.3.20.33.PM.mov

[alexstine]

@annezazu You have insights into who might be able to work on this? I know @draganescu has done a lot of work around toolbars here lately. Is this possibly related to ongoing work in #49634?

[jeryj]

@alexstine I'm happy to work on it, I was seeking feedback to make sure everyone is OK with this proposed shortcut behavior.

I noticed it while working on #49644. I could land this alongside that PR if y'all agree with the behavior change.

[alexstine]

@jeryj Sure, absolutely. I just wanted to make sure we were not duplicating efforts. Ping me when ready, happy to review/test the PR. 👍

[jeryj]

I looked into this for a bit. I thought it would be an easy fix to make things more readable and consistent, but I'm having a hard time making this work in a way that doesn't cause more problems than it creates. It is a nice hidden feature to know that you can move to the document toolbar if it's from an empty default block, I guess. I'll leave this open for now, but unfortunately I'm not sure how to do this in a simple way that preserves all the current behaviors.