Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Navigation Submenu Chevron Button Missing aria-expanded Attribute on load #50752

Closed
jeryj opened this issue May 18, 2023 · 2 comments
Closed

Missing Navigation Submenu Chevron Button Missing aria-expanded Attribute on load #50752

jeryj opened this issue May 18, 2023 · 2 comments
Labels
[Block] Navigation Affects the Navigation Block [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Bug An existing feature does not function as intended

Comments

@jeryj
Copy link
Contributor

jeryj commented May 18, 2023

Description

The Interactivity API for the Navigation block doesn't include the aria-expanded attribute for the submenu chevron button so the state of the submenu being expanded/collapsed is not announced to screen readers.

Step-by-step reproduction instructions

  1. Turn on your screen reader of choice
  2. Have a navigation with a submenu
  3. Go to the frontend of the site
  4. Use the keyboard to place focus on the submenu chevron icon
  5. The state of collapsed or expanded is not announced

On the non-interactivity API version of the navigation, the aria-expanded state is set on load so the state of "collapsed" is announced.
@jeryj jeryj added [Block] Navigation Affects the Navigation Block [Feature] Interactivity API API to add frontend interactivity to blocks. labels May 18, 2023
@jeryj jeryj changed the title Missing Navigation Submenu Chevron Button Missing aria-expanded Attribute on :oad Missing Navigation Submenu Chevron Button Missing aria-expanded Attribute on load May 18, 2023
@luisherranz luisherranz mentioned this issue May 19, 2023
Closed
22 tasks
@gziolo gziolo added the [Type] Bug An existing feature does not function as intended label May 19, 2023
@SantosGuillamot SantosGuillamot mentioned this issue May 19, 2023
Merged
@SantosGuillamot
Copy link
Contributor

Thanks a lot for reporting this 🙂 I created this pull request to handle that among other accessibility issues.

@luisherranz
Copy link
Member

Fixed by #50786.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Affects the Navigation Block [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gziolo @jeryj @luisherranz @SantosGuillamot