-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment: Add zoom and animation toggle for image lightbox #51055
Comments
I don't think we need the close X icon on the top right. I wonder, based on the videos, if the transition can be sped up a bit more. |
I also wonder if you all considered a very slight zoom on hover so it'd anticipate the behavior. |
@pablohoneyhoney Thanks for the ideas! Here are some thoughts:
These sound worth exploring — will give these a shot.
For this one, we recently received accessibility feedback on the close button and that it is important to have it:
Will keep all of this in mind as this feature gets implemented. |
It’s not a popup or a dialog with functionality though, you can literally hit the keyboard anywhere and it should "close", no shortcut needed. I quoted "close" because it's not even an opening behavior (which puts you in a new context with further actions), but a slight zooming behavior (same context, not critical for understanding any further text or functional information about the object itself), it’s not “closing” anything. In that vein, maybe “lightbox” (traditionally understood as a state hosting further actions like thumbnails, image info, carousel…) is not a clear name for this behavior anyways, I feel it has been misunderstood. |
It would be great if we could predicate this on Essentially, give content authors a choice as to whether they want a |
What problem does this address?
This builds on the image lightbox experiment using the Interactivity API, introduced in #50373, and is related to #49972 and #50029.
Some users prefer the effect of a zoom animation for the lightbox over a fade animation. Ideally, users would be able to select the animation they prefer.
What is your proposed solution?
Add support for a zoom animation to the lightbox, as well as a toggle for the behaviors UI, allowing users to select their preference when the lightbox is enabled for a particular block.
Initial explorations by @SantosGuillamot in the videos below and in this branch.
These explorations are originally from a comment in the initial PR.
Desktop
239522890-21e9aa36-3352-4b9c-9d06-50fdc821e205.mp4
Mobile
239522971-099fb143-1ab2-462e-9add-086cb032a6ff.mp4
Explanation
Lightbox.Zoom.mp4
The text was updated successfully, but these errors were encountered: