Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct URL to the style book #51121

Closed
hanneslsm opened this issue May 31, 2023 · 3 comments
Closed

Direct URL to the style book #51121

hanneslsm opened this issue May 31, 2023 · 3 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Style Book [Package] Edit Site /packages/edit-site [Type] Enhancement A suggestion for improvement.

Comments

@hanneslsm
Copy link

What problem does this address?

When creating custom themes, I'm editing the theme.json.
Often times I am checking how those changes look in the editor. For that I'm using the Style Book - however I have to navigate to it every time I refresh the page to load the newest changes from my theme.json.
To make this experience smoother, it'd be great if I could directly open the Style Book, probably by using a specific URL.

@aurooba aurooba added [Package] Edit Site /packages/edit-site [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 2, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 19, 2023
@ramonjd
Copy link
Member

ramonjd commented Oct 17, 2024

I like this idea. I suppose it'd would have to be activated via URL param.

I'm thinking a couple of things:

  • the site editor should automatically open the global styles sidebar with the URL path contains /wp_global_styles. At the moment it doesn't.
  • Then, via another param or a subroute of /wp_global_styles, the style-book could be triggered to open

Something like this:

2024-10-17.14.56.45.mp4

And the very dodgy code: #66186

However, we'd meed to think about state: the url param should update as style book is closed. Also whether the URL should be in the navigation history.

It makes me think that global styles needs its own editor view entirely, or perhaps some modal or other separate UI from the template/post editor.

@ramonjd
Copy link
Member

ramonjd commented Oct 17, 2024

@richtabor
Copy link
Member

Here's something that might influence things:

I came to say the same.

We already have wp-admin/site-editor.php?path=%2Fwp_global_styles, and with #65619 in the works I don't think we'll need (or should commit to maintaining) a direct link for style book. /wp_global_styles will be a more meaningful and direct styling experience. I'll mark this as not planned for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Style Book [Package] Edit Site /packages/edit-site [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants