Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content editing in site editor guidance #51822

Closed
SaxonF opened this issue Jun 23, 2023 · 10 comments · Fixed by #52014
Closed

Content editing in site editor guidance #51822

SaxonF opened this issue Jun 23, 2023 · 10 comments · Fixed by #52014
Assignees
Labels
Blessed for major release Can be iterated during a WordPress beta period [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. Needs Design Feedback Needs general design feedback. [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.

Comments

@SaxonF
Copy link
Contributor

SaxonF commented Jun 23, 2023

What problem does this address?

Provide some early guidance for users who are yet to experience content editing in the site editor.

What is your proposed solution?

Re-use the welcome modal in two different scenarios.

A user first hits the site editor with a page in context (e.g. after clicking a page in the pages sidebar)

welcome-page.mov

A user first switches to editing a template from a page

welcome-template.mov

The video files are attached below. We may need to convert these to gif .

toolbar-back.mp4
sidebar-demo.mp4

@WordPress/gutenberg-design

@jasmussen
Copy link
Contributor

Nice one. Remember to choose the modern color scheme for demo work, though:

Screenshot 2023-06-23 at 10 21 14

I wonder, can we/should we be more abstract in the representation, a la the welcome guide?

Screenshot 2023-06-23 at 10 22 00

Screenshots and video age extremely quickly given how much UI work we still have to do, and if we can abstract this down, it'll likely have a longer shelf life.

@jameskoster
Copy link
Contributor

I'd +1 the notion for a more abstract graphic – it'll be simpler to maintain. Using the Guide component probably makes sense too.

@richtabor
Copy link
Member

I wonder, can we/should we be more abstract in the representation, a la the welcome guide?

How were this original ones made?

@SaxonF
Copy link
Contributor Author

SaxonF commented Jun 23, 2023

The thought was that since this is such a significant change and we don't currently have a tour component a more literal representation would be better in the short term. Long term we can change.

@noisysocks noisysocks added [Type] Enhancement A suggestion for improvement. [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. labels Jun 25, 2023
@noisysocks
Copy link
Member

Will we want this in 6.3?

@SaxonF
Copy link
Contributor Author

SaxonF commented Jun 25, 2023

@noisysocks Ideally yes

@noisysocks noisysocks added the Needs Design Feedback Needs general design feedback. label Jun 26, 2023
@noisysocks
Copy link
Member

Cool. Remove the Needs Design Feedback label when you're ready for me to start building it out. Since it's onboarding for a feature that's already landing in 6.3 it's fine to add this during the beta period.

@jasmussen
Copy link
Contributor

I think we can go with a GIF/screenshot for now (though we want to be mindful of the compression), and then ticket a followup to replace it with an abstracted version later on.

That said, I would call it a blocker that it's using the classic WordPress blue. The imagery should use the modern colors.

@ndiego ndiego moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jun 26, 2023
@ndiego ndiego moved this from ❓ Triage to 📥 Todo in WordPress 6.3.x Editor Tasks Jun 26, 2023
@SaxonF
Copy link
Contributor Author

SaxonF commented Jun 27, 2023

Thanks @jasmussen, I'll update GIF tomorrow with modern theme enabled. @noisysocks you should be free to work on this now when you have a moment.

@priethor priethor added [Priority] High Used to indicate top priority items that need quick attention Blessed for major release Can be iterated during a WordPress beta period labels Jun 27, 2023
@priethor
Copy link
Contributor

Related Trac ticket

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 28, 2023
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.3.x Editor Tasks Jul 3, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blessed for major release Can be iterated during a WordPress beta period [Feature] Page Content Focus Ability to toggle between focusing on editing the page and editing the template in the site editor. Needs Design Feedback Needs general design feedback. [Priority] High Used to indicate top priority items that need quick attention [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants