Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent pattern creation modals #51941

Closed
richtabor opened this issue Jun 26, 2023 · 2 comments · Fixed by #51946
Closed

Inconsistent pattern creation modals #51941

richtabor opened this issue Jun 26, 2023 · 2 comments · Fixed by #51946
Assignees
@SaxonF
Labels
[Block] Pattern Affects the Patterns Block Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@richtabor
Copy link
Member

These should probably use the same modals.

When creating from the "Create pattern" control in the block toolbar, and from the Library.

CleanShot 2023-06-26 at 16 32 17 CleanShot 2023-06-26 at 16 32 47
@richtabor richtabor added [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. [Block] Pattern Affects the Patterns Block labels Jun 26, 2023
@richtabor
Copy link
Member Author

richtabor commented Jun 26, 2023 •
edited
Loading

The "Turn this block into a pattern to reuse later" copy can probably be removed. It's not particularly clear/helpful.

And you're not turning any block into a pattern in this flow; you've just selected the +.

@SaxonF SaxonF mentioned this issue Jun 26, 2023
Merged
@SaxonF
Copy link
Contributor

SaxonF commented Jun 26, 2023

#51946

@aaronrobertshaw aaronrobertshaw mentioned this issue Jun 27, 2023
Closed
92 tasks
@ndiego ndiego moved this to 🏗️ In Progress in WordPress 6.3.x Editor Tasks Jun 27, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.3.x Editor Tasks Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaxonF SaxonF

Labels
[Block] Pattern Affects the Patterns Block Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.3.x Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pattern creation modal in library WordPress/gutenberg
2 participants
@SaxonF @richtabor