Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Palette: Site editor-related commands appear in non-block themes #52154

Closed
t-hamano opened this issue Jun 30, 2023 · 1 comment · Fixed by #53718
Closed

Command Palette: Site editor-related commands appear in non-block themes #52154

t-hamano opened this issue Jun 30, 2023 · 1 comment · Fixed by #53718
Assignees
@t-hamano
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Commands /packages/commands [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Jun 30, 2023 •
edited
Loading

Description

For non-block themes, the Site Editor is not accessible, but the command palette allows site editor-related commands to be executed. As a result, if you execute a command, you will receive a message indicating that access is not allowed.

Ideally, I think these commands should be disabled for non-block themes.

Step-by-step reproduction instructions

  1. Go to Appearance > Themes and activate non block theme (i.e Twenty Twenty)
  2. Add new post
  3. Open "Command Center" using keyboard short cut. Windows: Ctrl + k / Mac: ⌘ + K
  4. Type "Templates" and click on "Open Templates" link. You will be redirected to WordPress page.

Screenshots, screen recording, code snippet

2ba8527326f8cb91c5776f098819a1c4.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@skorasaurus skorasaurus added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended [Package] Commands /packages/commands labels Jul 6, 2023
@annezazu annezazu moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jul 11, 2023
@firoz2456
Copy link

I can replicate this with WordPress 6.3-beta4.

@annezazu annezazu moved this from ❓ Triage to 📥 Todo in WordPress 6.3.x Editor Tasks Jul 14, 2023
@t-hamano t-hamano mentioned this issue Jul 24, 2023
Merged
@ndiego ndiego moved this from 📥 Todo to 🐛 Punted to 6.3.1 in WordPress 6.3.x Editor Tasks Jul 24, 2023
@ntsekouras ntsekouras mentioned this issue Jul 26, 2023
Merged
This was referenced Jul 28, 2023
Merged
Closed
@ndiego ndiego moved this from 🐛 Punted to 6.3.1 to ❓ Triage in WordPress 6.3.x Editor Tasks Aug 9, 2023
@Mamaduka Mamaduka mentioned this issue Aug 14, 2023
Closed
@t-hamano t-hamano mentioned this issue Aug 16, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 16, 2023
@github-project-automation github-project-automation bot moved this from ❓ Triage to ✅ Done in WordPress 6.3.x Editor Tasks Aug 21, 2023
@t-hamano t-hamano mentioned this issue Aug 21, 2023
Closed
@t-hamano t-hamano mentioned this issue Sep 3, 2023
Closed
@MadtownLems MadtownLems mentioned this issue Sep 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t-hamano t-hamano

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Commands /packages/commands [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.3.x Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Command Palette: Proper handling of page/post links in all themes WordPress/gutenberg
3 participants
@skorasaurus @firoz2456 @t-hamano