Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP 6.3-beta3: pattern export and import ignores sync type #52333

Closed
bvlgn opened this issue Jul 5, 2023 · 1 comment · Fixed by #52346
Closed

WP 6.3-beta3: pattern export and import ignores sync type #52333

bvlgn opened this issue Jul 5, 2023 · 1 comment · Fixed by #52346
Assignees
@glendaviesnz
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@bvlgn
Copy link

bvlgn commented Jul 5, 2023

Description

If you export a synced pattern the sync type (synced/unsynced) is not stored in the json file.
So an imported unsynced pattern will always become a synced pattern after import and the user has no way to change that to unsynced.

Step-by-step reproduction instructions

  1. Go to /wp-admin/edit.php?post_type=wp_block
  2. Export a synced pattern
  3. Permanently delete the pattern you just exported
  4. Import the pattern and notice it now is marked as fully synced and you cannot change that

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@glendaviesnz glendaviesnz added [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended labels Jul 5, 2023
@glendaviesnz
Copy link
Contributor

Thanks for reporting @bvlgn

This was referenced Jul 5, 2023
Closed
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 5, 2023
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.3.x Editor Tasks Jul 6, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glendaviesnz glendaviesnz

Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.3.x Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patterns: Add handling of sync status to the wp-admin patterns list page WordPress/gutenberg
3 participants
@glendaviesnz @bvlgn @priethor