Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The frame in Site Editor is sometimes not clickable - so we can't enter edit mode #52402

Closed
getdave opened this issue Jul 7, 2023 · 3 comments · Fixed by #52406
Closed

The frame in Site Editor is sometimes not clickable - so we can't enter edit mode #52402

getdave opened this issue Jul 7, 2023 · 3 comments · Fixed by #52406
Assignees
@draganescu
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Jul 7, 2023 •
edited by draganescu
Loading

100vh seems to not be quite right. If you scroll the editor canvas down then you are able to get to a portion of the canvas where clicking on it doesn't open edit mode.Should it be 100%? I'm not certain, this CSS confuses me. I'm not sure what body's sizing is relative to 😅

Originally posted by @noisysocks in #51973 (comment)

Kapture.2023-07-07.at.15.16.11.mp4
@getdave getdave added the [Type] Bug An existing feature does not function as intended label Jul 7, 2023
@getdave getdave moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jul 7, 2023
@getdave getdave changed the title Focus mode canvas height not "full height" Site Editor canvas height not "full height" and thus not all clickable Jul 7, 2023
@draganescu draganescu added the [Priority] High Used to indicate top priority items that need quick attention label Jul 7, 2023
@draganescu draganescu moved this from ❓ Triage to 📥 Todo in WordPress 6.3.x Editor Tasks Jul 7, 2023
@draganescu draganescu added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Jul 7, 2023
@draganescu draganescu changed the title Site Editor canvas height not "full height" and thus not all clickable The frame in Site Editor is sometimes all clickable - so we can't enter edit mode Jul 7, 2023
@draganescu draganescu self-assigned this Jul 7, 2023
@draganescu draganescu changed the title The frame in Site Editor is sometimes all clickable - so we can't enter edit mode The frame in Site Editor is sometimes not clickable - so we can't enter edit mode Jul 7, 2023
@draganescu
Copy link
Contributor

It seems removing the min height of the html and the height of the body fixes things in FF at least.

@getdave
Copy link
Contributor Author

getdave commented Jul 7, 2023 •
edited
Loading

When we fix this we need to be sure to retain the "full height" as this is important for Navigation Focus Mode.

@draganescu
Copy link
Contributor

This bug was actually introduced by fixing the problem when content is smaller than viewport height (e.g. navigations). We need to apply the fix selectively somehow, as the normal template browsing does not need any fix.

@draganescu draganescu mentioned this issue Jul 7, 2023
Merged
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.3.x Editor Tasks Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draganescu draganescu

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.3.x Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix entering edit mode in site editor WordPress/gutenberg
2 participants
@draganescu @getdave