Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command for renaming a pattern #52651

Closed
richtabor opened this issue Jul 14, 2023 · 5 comments
Closed

Add command for renaming a pattern #52651

richtabor opened this issue Jul 14, 2023 · 5 comments
Assignees
@aaronrobertshaw
Labels
[Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Package] Commands /packages/commands [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

When in pattern focus mode I'd expect to be able to quickly rename a pattern. Currently that's only possible via the Patterns Site Editor grid view. The command should be suggested when in this context and could invoke the existing modal for renaming.

In the future it would be interesting to explore in-command-palette actions, like triggering a view for renaming. 🤔

Edit pencil icon / "Rename"

CleanShot 2023-07-14 at 15 55 13 CleanShot 2023-07-14 at 15 58 54
@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Package] Commands /packages/commands labels Jul 14, 2023
@richtabor
Copy link
Member Author

We should have the same for renaming a custom template as well.

@aaronrobertshaw aaronrobertshaw moved this to Todo in Patterns Aug 3, 2023
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 14, 2023
@aaronrobertshaw aaronrobertshaw moved this from Todo to In Progress in Patterns Aug 14, 2023
@aaronrobertshaw aaronrobertshaw mentioned this issue Oct 10, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 10, 2023
@aaronrobertshaw
Copy link
Contributor

aaronrobertshaw commented Oct 12, 2023 •
edited
Loading

A PR adding a rename pattern command has been merged (#55188).

Renaming of templates is still outstanding for the moment.

@richtabor
Copy link
Member Author

A PR adding a rename pattern command has been merged (#55188).

Nice! A quick follow-up would be to have it as a suggested command when you trigger the palette from the pattern editor. And also to use the small edit pencil icon.

@aaronrobertshaw aaronrobertshaw mentioned this issue Oct 13, 2023
Merged
@aaronrobertshaw
Copy link
Contributor

have it as a suggested command when you trigger the palette from the pattern editor

I've put up a follow-up PR for this over in #55332

@aaronrobertshaw aaronrobertshaw mentioned this issue Oct 13, 2023
Closed
@richtabor
Copy link
Member Author

Closed via #55332.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Patterns Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Package] Commands /packages/commands [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Patterns
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richtabor @aaronrobertshaw