Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nofollow to Link UI in Nav and Buttons blocks #54091

Open
getdave opened this issue Aug 31, 2023 · 6 comments
Open

Add nofollow to Link UI in Nav and Buttons blocks #54091

getdave opened this issue Aug 31, 2023 · 6 comments
Labels
[Block] Buttons Affects the Buttons Block [Block] Navigation Link Affects the Navigation Link Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Aug 31, 2023

Following on from #53945 we should add Nofollow control to other instances of the Link UI. Specifically:

  • Navigation
  • Buttons

If and when this merges we should follow up to add this control elsewhere:

  • Navigation links
  • Buttons block

Originally posted by @getdave in #53945 (comment)

@getdave getdave added [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Block] Buttons Affects the Buttons Block [Block] Navigation Link Affects the Navigation Link Block labels Aug 31, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 1, 2023
@bangank36
Copy link
Contributor

@getdave can I contribute to the Button block link editor with nofollow control? Thanks
image

@getdave
Copy link
Contributor Author

getdave commented Sep 1, 2023

@getdave can I contribute to the Button block link editor with nofollow control? Thanks image

Absolutely! That would be great. You would need to wire everything up to save the nofollow into the block attributes. I look forward to your PR. Please ping me.

@bangank36
Copy link
Contributor

@getdave with the Button Link has been merged #54110, do you think Navigation Links should be next, or do you have other plan for it? Thanks

@getdave
Copy link
Contributor Author

getdave commented Sep 21, 2023

Is there a strong use case for nofollow on Navigation links? How often would one wish to add a link to a Navigation that points to another site? I guess if it were a Navigation other than one in a header of the website perhaps that might happen?

@bangank36
Copy link
Contributor

I think user may want to add nofollow to External link Item on the Navgation? Actually there are a handful of articles that help users to add nofollow to their Navigation items, eg: /how-to-add-nofollow-links-in-wordpress-navigation-menus/, I guess users will expect the same with the Navigation block

@skorasaurus
Copy link
Member

can close #13542 when this is also closed

@skorasaurus skorasaurus added [Block] Buttons Affects the Buttons Block and removed [Block] Buttons Affects the Buttons Block labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Buttons Affects the Buttons Block [Block] Navigation Link Affects the Navigation Link Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants