Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Variant list does not update immediately following upload of new variant #54945

Closed
ironprogrammer opened this issue Sep 29, 2023 · 2 comments · Fixed by #57817
Closed
Assignees
Labels
[Feature] Typography Font and typography-related issues and PRs [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@ironprogrammer
Copy link
Contributor

Description

On the font management Library tab, a font variant's detail list is not updated immediately following upload of a new variant to that same font. I expect the variant list to include newly uploaded variants when switching from the Upload tab to Library.

Note that the variant list does update after navigating back to the full registered fonts list and re-entering the font detail screen.

Step-by-step reproduction instructions

  1. Open the font management modal.
  2. In the Upload tab, add a single variant of a new font, and confirm the upload succeeded.
  3. Click the Library tab, noting "1/1 variants" for the newly added font.
  4. Click into the font's variant detail list, noting the single variant that was added.
  5. Click the Upload tab, and add a different variant for that same font, and confirm the upload succeeded.
  6. Click the Library tab, noting that the new variant is missing from the list.
  7. Click the "back" button under the Library tab to view the registered fonts list, then click back into the new font's variant detail list.
  8. Note that the list now includes the additional variant.

Screenshots, screen recording, code snippet

Demonstration to reproduce issue:
library-list-refresh

Environment info

  • Hardware: MacBook Pro Apple M1 Pro
  • OS: macOS 13.6
  • Browser: Safari 16.6, Google Chrome 117.0.5938.132
  • Server: nginx/1.25.2
  • PHP: 7.4.33
  • WordPress: 6.4-beta1-56730-src
  • Theme: twentytwentythree v1.2
  • Active Plugins:
  • gutenberg v16.7.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ironprogrammer ironprogrammer added [Type] Bug An existing feature does not function as intended [Feature] Typography Font and typography-related issues and PRs labels Sep 29, 2023
@ironprogrammer
Copy link
Contributor Author

This is something to consider when addressing #54779.

@mikachan
Copy link
Member

I've just tested this out using the reproduction steps above and I can successfully replicate this.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 12, 2024
@mikachan mikachan moved this from 📥 Todo to 🔎 Needs Review in WordPress 6.5 Editor Tasks Jan 12, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.5 Editor Tasks Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Typography Font and typography-related issues and PRs [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants