Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template vs Content Editing UX: enable the ability to hit return from post title to begin writing #54984

Open
annezazu opened this issue Oct 2, 2023 · 8 comments · May be fixed by #63484
Open
Assignees
Labels
[Block] Post Title Affects the Post Title Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

annezazu commented Oct 2, 2023

What problem does this address?

I wanted to pull this experience out of this prior issue #42481 as it greatly impacts the writing experience in the Site Editor and has an outsized impact compared to locked blocks due to the current UX. Currently, when you click on the Post Title, you're unable to click return to start writing on the first line. This differs from the Post Editor, making it hard to start writing from the top of a page:

Screen.Recording.2023-10-02.at.11.45.49.AM.mov

This came up previously as part of FSE Outreach Program feedback that I'll reshare below:

I created a new page in Site Editor > Pages and titled it ‘Resume’.
I added content such as headings and text and tried to insert a table of contents block.
I wanted to insert the table of contents block between the title and the first block, so I moved the cursor to the page title with the mouse and pressed enter, but could not move it to the content area.
When creating pages in the block editor as before, I was able to bring the cursor to the top of the content using the same operation (strictly speaking, I was able to insert a paragraph block at the beginning), so I felt that a similar UX would be fine.

What is your proposed solution?

Allow the ability to hit return out of the Post Title block.

cc @SaxonF

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Oct 2, 2023
@annezazu annezazu added this to Polish Oct 5, 2023
@annezazu annezazu moved this to Needs development in Polish Oct 5, 2023
@annezazu
Copy link
Contributor Author

annezazu commented Dec 6, 2023

If I'm reading this PR correctly #56671, this can be closed out as resolved. I'll loop back to double check with GB 17.3.

@richtabor
Copy link
Member

Doesn't seem to fix this; testing on trunk.

@annezazu
Copy link
Contributor Author

annezazu commented Dec 7, 2023

😭 Bummer. @youknowriad did something change here? This is noted in the PR description:

For example this PR brings some niceties of the post editor to the site editor post only mode like hitting "Enter" from the post title to go to the post content.

This is such a frustrating sticking point right now.

@youknowriad
Copy link
Contributor

Nothing changed, here, it's currently implemented when you disable "template previewing" from the template dropdown. I don't think it makes sense to enable this elsewhere in the "regular mode", the reason is simple, the post content block won't always follow the post title block, it depends on the template.

@jasmussen
Copy link
Contributor

jasmussen commented Dec 8, 2023

Title to post content through Enter, the sticking point here is mainly that it selects the block first. To Riad's point, post content isn't always below the title. A quick GIF showing this case:

enter

Shown here, title, featured image, post content. The latter is editable, but pressing Enter in the title does nothing. Because I'm editing page content in the site editor and the list view shows all three blocks locked.

But I can still select the featured image block with the cursor. Can we just make it so pressing Enter selects the next block? In the example above, it'd select the featured image. Enter again would focus the post content block.

@annezazu
Copy link
Contributor Author

I think that's a great solution -- it moves you to the next editable field.

@ellatrix ellatrix added the [Block] Post Title Affects the Post Title Block label Jul 12, 2024
@ellatrix ellatrix linked a pull request Jul 12, 2024 that will close this issue
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 12, 2024
@annezazu
Copy link
Contributor Author

annezazu commented Dec 3, 2024

This is even more apparent now that the template is shown for all new pages #62304 (comment)

@ellatrix
Copy link
Member

ellatrix commented Dec 4, 2024

I can revisit #63484 soon, as far as I remember it's just a matter of looking at the e2e tests and make adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Title Affects the Post Title Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Status: Needs development
Development

Successfully merging a pull request may close this issue.

5 participants