Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-between inserter ignores locking via template_lock #5531

Closed
2 tasks
kraftner opened this issue Mar 9, 2018 · 1 comment · Fixed by #5574
Closed
2 tasks

In-between inserter ignores locking via template_lock #5531

kraftner opened this issue Mar 9, 2018 · 1 comment · Fixed by #5574
Assignees
@jorgefilipecosta
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@kraftner
Copy link

kraftner commented Mar 9, 2018

Issue Overview

If you lock a template as explained in the docs you can afterwards still add new paragraph blocks by using the "in-between inserter".

Steps to Reproduce (for bugs)

  1. Define a template and set template_lock to all or insert
  2. Edit a post
  3. Click between the blocks defined by the template

Expected Behavior

I'd expect the "in-between inserter" to be disabled as well by setting template_lock to all or insert

Current Behavior

You can still insert paragraph blocks. Even if the core/paragraph block type is disabled via allowed_block_types

Possible Solution

Screenshots / Video

Related Issues and/or PRs

Todos

  • Tests
  • Documentation
@jasonbahl
Copy link

related to #5521

@jorgefilipecosta jorgefilipecosta self-assigned this Mar 9, 2018
@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended [Status] In Progress Tracking issues with work in progress labels Mar 9, 2018
@jorgefilipecosta jorgefilipecosta mentioned this issue Mar 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide insertion point if a template lock exists. WordPress/gutenberg
3 participants
@jasonbahl @kraftner @jorgefilipecosta