New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit inconsistency on final padding parameter #55329

Closed

tysonlmao opened this issue Oct 13, 2023 · 0 comments · Fixed by #67168

Assignees

Labels

[Block] Navigation Good First Issue [Status] In Progress [Type] Bug

tysonlmao commented Oct 13, 2023

The clamp function's final parameter, set at 20em, deviates from the uniform use of "rem" for padding values in the lines above, introducing inconsistency. Is this a typo?

https://github.com/WordPress/gutenberg/blob/617138a05ec848656dc9df5f1943dc03ca8e5616/packages/block-library/src/navigation/style.scss#L512C69-L512C69

jordesign added [Type] Bug [Block] Navigation labels

getdave added the Good First Issue label

getdave mentioned this issue

Use rems for Nav overlay left padding #67168

Merged

github-actions bot assigned getdave

github-actions bot added the [Status] In Progress label

getdave closed this as completed in #67168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment