Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's possible to rename a custom pattern categories using existing category names #55564

Closed
jameskoster opened this issue Oct 24, 2023 · 0 comments · Fixed by #55607
Closed
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

Follow-up to #55035.

To reproduce:

  1. Create a custom pattern category (add new pattern, type a non-existing category name into Categories input)
  2. Rename category (via ellipsis menu in top right)
  3. Choose an existing category name
  4. See duplicate categories in the Pattern management sidebar:
Screenshot 2023-10-24 at 10 57 37

Potential solutions

  1. Validate and do not allow duplicate names (this would be consistent with the post category experience)
  2. Allow duplication, but append the name with -1, (Copy), or similar.

I'd lean towards the first option, but keen to hear other thoughts and ideas.

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Oct 24, 2023
@talldan talldan self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants