-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data views: Expanding quick-actions for Pages #55628
Comments
An immediate thought is that this is a lot of repeated instances of the word "Edit". A more expanded question is whether we can bunch these together as a single, or a few, grouped quick-edit instances. "Edit properties" or "Edit details", something in that vein. |
We could probably omit the repetitive 'Edit...' prefix 👍 The argument to keep each action separate is that they can all be invoked from different flows, e.g.: clicking the values in the table row (inline editing), or bulk actions. Some (like swapping the template) can be invoked from the main document inspector in edit mode too. So it's a case of reusing as much as possible to establish consistency across. That said, grouping could potentially work similar to wp-admin (albeit with a more considered design). IE a single "Quick edit" action that opens a modal containing all the document meta. Alternatively the quick actions menu itself might be organised to make use of flyouts. I'll try a couple of mockups. |
This looks real interesting James! |
Might work. Some of the answers might present themselves as we explore in a PR, but I just wonder if in some cases, a single modal opening from the menu, rather than navigating the dropdown, is easier. |
I have a slight preference for discrete flows per action because it's more lightweight / reusable. But totally open to trying both approaches in a PR 👍 |
This issue is really connected to inline editing of fields, and should be addressed probably when we implement that. The goal is to define descriptions for fields, which will generate the editing of them. |
I think the recent Inspector work may influence the direction here. Closing for now, easy to re-open if required. |
#55488 enables 'quick actions' in data views. For pages this initially includes primary actions; View, Trash, and the secondary actions: Edit and View revisions.
We can expand upon this by adding:
I suspect much of the design work can occur alongside PR's. But if there's anything we need to dive deeper on before work begins let me know @ntsekouras.
It's also worth noting that the modals here could also potentially be opened when clicking values in table views (#55101), and when performing bulk actions (#55098).
cc @WordPress/gutenberg-design for further feedback.
The text was updated successfully, but these errors were encountered: