-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HeadingLevelDropdown: tooltip for a menu item obscures the next item #55927
Comments
@talldan thanks for the ping.
As such, the accessible name needs to be exposed visually as we do for all icon buttons. Rather, in this case the problem is in the tooltip positioning.
I can think of two options:
In my opinion, the second option would also bring in better user experience. Now that the dropdown is vertical, there is no need to save horizontal space by using shorter visible text H1, H2, etc.
Screenshot after quickly editing |
This issue has also been discussed in #50402. Another option I would suggest is to display both the icon and the text, as mentioned in this comment. It may be a little redundant, but I think we can visually understand which level is selected without having to adjust CSS. |
Hi @t-hamano, good point. I'd be in favor of using both the icon and visible text. Having both icon and visible text is not uncommon in many big applications around, and that pattern is used for good reasons. See also prior discussion on #46003 I'd be in favor of closing this issue in favor of #50402 and continue the conversation there, as this issue is basically a duplicate. Please do feel free to reopen if I'm missing something. |
Steps to reproduce:
A very minor bug, but I found the behavior very unpleasant when I encountered it.
The text was updated successfully, but these errors were encountered: