Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views: Improve title display for untitled records #56154

Closed
jameskoster opened this issue Nov 15, 2023 · 12 comments
Closed

Data views: Improve title display for untitled records #56154

jameskoster opened this issue Nov 15, 2023 · 12 comments
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Nov 15, 2023

In data views, records without a title appear as "(no-title)". If they're also private they appear as "Private: ". It would be good to improve and align this.

Untitled public records should ideally appear as "Untitled $post_type". Private records can be denoted via badge, (similar to #57763):

Screenshot 2024-04-16 at 11 38 21
Original issueIf a page is set to private and has no title, it appears like so in the pages data view: Screenshot 2023-11-15 at 15 46 31

Regular title-less pages display a 'no-title' string:

Screenshot 2023-11-15 at 15 49 02

We might use that in this scenario too, IE: "Private: no-title".

Bonus points if that string can display as "No title", or perhaps "Untitled". cc @WordPress/gutenberg-design for thoughts on that. For reference in wp-admin title-less pages are displayed as "(no title)".

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Nov 15, 2023
@jasmussen
Copy link
Contributor

Good catch, there needs to be some text there to indicate what's up. This seems like a problem where we can look at other platforms, just as a quick example, an email with no subject shows up in Gmail as (no subject), perhaps more relevant, an untitled Google Doc shows up as "Untitled document":

cropped screenshot showing "Untitled document" in Google Docs

I think we can do better than no-title. Untitled feels a baseline, Untitled [post-type] (i.e. Untitled post) might be better still.

Have there separately been any thought given to showing a brief snippet of text from the post itself? Like how in Gmail it shows first the subject, and then the first elided line of text from the email in the next column?

cropped screenshot of Gmail, showing a row of "(no subject)" followed by a snippet of text from the email in the next column

@jameskoster
Copy link
Contributor Author

"Untitled [post-type/format]" seems good to me.

Have there separately been any thought given to showing a brief snippet of text from the post itself?

We could include a view option for the excerpt. Might be worth a ticket.

@jasmussen

This comment was marked as off-topic.

@jameskoster

This comment was marked as off-topic.

@jameskoster jameskoster added the Needs Dev Ready for, and needs developer efforts label Apr 16, 2024
@jameskoster jameskoster changed the title Pages data view: title-less private page appearance can be confusing Data views: Improve title display for untitled records Apr 16, 2024
@jasmussen jasmussen moved this from Next to In Dev in Design priorities May 8, 2024
@jasmussen jasmussen moved this from In Dev to Need Dev in Design priorities May 8, 2024
@colorful-tones
Copy link
Member

Hi folks,
We are only one week away from the Beta 1 cut-off date for WordPress 6.6. We (the editor triage leads of the 6.6 release) have decided to remove it from the WordPress 6.6 Editor Tasks project board.

@youknowriad
Copy link
Contributor

Screenshot 2024-07-12 at 10 09 59 AM

This is what the tables show today.

  • Private: for empty private pages
  • (no title) for empty pages that are not private.

What do you think we should do?

IMO, we should show neither "private" nor a badge for private pages / posts as there's already a "status" column and we should consistently show (no title) because that's how posts/pages that are empty are rendered everywhere in WordPress.

@jasmussen
Copy link
Contributor

Your suggestion sounds good to me. Show (no title) consistently—though even that we could potentially improve across the software, it's curious that the "no" is lowercase. And with Status prominently shown, I'd tend to agree it's not useful as a prefix. What if you try to set the world on fire by naming your post "Private:"? :)

@youknowriad
Copy link
Contributor

Ok, so it turns out that we have the right logic in place but that for some reason the "pages" endpoint returns "Private:" as rendered title for private pages with empty titles.

@youknowriad
Copy link
Contributor

It's not clear to me what the exact path forward is here but I opened this trac ticket to get more information and figure out what needs to be done https://core.trac.wordpress.org/ticket/61639

@youknowriad
Copy link
Contributor

Going to close this in favor of the core ticket as it's going to be solved there.

@github-project-automation github-project-automation bot moved this from Needs Dev to Done in Design priorities Jul 12, 2024
@jameskoster
Copy link
Contributor Author

I still think "Untitled $post_type" would be better than "(no title)", if trivial to implement.

@youknowriad
Copy link
Contributor

It's trivial to implement but I think consistency prevails personally. If we ware to show "Untitled $post_type", I think we should show It everywhere and not just dataviews and I believe that is a different issue with a larger scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

No branches or pull requests

4 participants