Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block browser library iterations #5689

Closed
karmatosed opened this issue Mar 18, 2018 · 7 comments
Closed

Block browser library iterations #5689

karmatosed opened this issue Mar 18, 2018 · 7 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback.

Comments

@karmatosed
Copy link
Member

karmatosed commented Mar 18, 2018

This issue is a series of iterations for the block browsing library. These are aimed at solving a number of issues:

  • An extra menu item / scroll area using ' ... ' is added, a convention used a lot on mobile and allows us to look to have extending to this menu, for example maybe allowing favourites.
  • Clear, large hit areas for blocks. This not only visually helps but also allows for easier accessibility by having wider areas to select.

Props to @iamthomasbishop for the inspiration on block buttons and more, through his mobile work.

Along with this, we have a clearer, lighter header by removing the tab backgrounds.

blocklibrary-iteration

@karmatosed karmatosed added [Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback. labels Mar 18, 2018
@stefanos82
Copy link

To be honest, I wanted to bring this up today after I briefly tested Elementor and liked their "big buttons" approach.

When I first heard about Gutenberg, I thought it would look something like this by default.

@karmatosed I really like this approach.

Cheers 👍

@davewhitley
Copy link
Contributor

Here's what it looked like before

screen shot 2018-03-23 at 12 51 40 pm

@davewhitley
Copy link
Contributor

I like it! The search field might be more obvious with an icon, or maybe it gets focus by default after clicking on the add button?

The ... should probably be an icon. Right now, it's hard to see. I think it this case, I'd prefer a vertical ... icon as seen in many Android apps.

@jasmussen
Copy link
Contributor

Part of this was addressed in #5743, notably lighter tabs and bordered blocks for a more distinct hit area.

Next steps I'd like to address, as part of this ticket and ensurng discussion:

  • making the gradient at the bottom much improved — it's actually already there but it's a shadow, so it sort of disappears into the bottom shadow as well.
  • add a search icon — great thoughts everyone
  • search focus style improvements are being explored separately in Try: Make input styles consistent #5605

I would suggest we close this ticket as fixed once those fixes are in. Notably because this one is very complicated to build, and not urgently necessary:

An extra menu item / scroll area using ' ... ' is added, a convention used a lot on mobile and allows us to look to have extending to this menu, for example maybe allowing favourites.

Even if in a closed ticket, we can revisit this pattern if and when it becomes necessary to add more items to the tabbar.

What do you think?

@karmatosed
Copy link
Member Author

I think close but maybe open an issue to have that menu implemented and put for future release. Does that sound good?

@jasmussen
Copy link
Contributor

I think close but maybe open an issue to have that menu implemented and put for future release. Does that sound good?

I think that could work as a way to store the mockups, perhaps tagged Customization. Right now, as I noted, it doesn't feel like there's a pressing need for additional tabs in that menu, but if/when that need comes, it can be revisited.

@karmatosed
Copy link
Member Author

Closing as opening new issue to include in Customization focus for the menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

4 participants