-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap template makes page unresponsive when preview a lot of content #59843
Comments
Noting for triage that I can't replicate with 6.5 RC2: Screen.Recording.2024-03-14.at.8.53.31.AM.movI then tried replicating with Gutenberg 17.9.0 but couldn't either! Can you provide a video of what's happening @JulienGardair? |
This happened as mentioned with WordPress 6.4.3 and heavier content, such as containing multiple images rather than just text. |
Well after more testing today, it seems like the error might come from a pattern I have that includes a query loop. |
If you'd like to share the contents of the pattern here, I can try to replicate too and see what might be going on. We definitely don't want any errors for patterns with query loops either :D Thanks for continuing to test and looping back either way. It's a huge help. |
painting-cutouts-query.json |
Thanks so much for your patience. I'm on the WordPress 6.5 release squad and the last two weeks have been quite stressful (and exciting) to get everything lined up. I'm just now finally looping back here. I tried to import the pattern you created but got a wild error: In any case, I recreated based on your description and found I could swap the templates, but it "flickers": Screen.Recording.2024-03-29.at.11.54.44.AM.movI've opened a new issue to cover this "flickering" effect in the swap preview!
I couldn't agree more :D |
Thank you! I can only imagine! I had the flickering issue as well. |
:D I love your excitement and please keep opening issues as you use the latest & greatest. You never know when you'll find a bug that'll save headaches for millions (part of the fun on working on a project of this scale). Here's that issue on flickering btw: #60309
:D Here's where you can follow along with what's currently being thought of for 6.6 there: #59819 (comment) In particular, there's a lot of discussion around how the UI will look and work that might be of interest to you: #59813 (comment) |
Thanks! I guess I need to download the coming testing versions (is it how you get access?) in order to participate in the discussions as it is a bit abstract to understand the UI through the description of the issues... |
I'm also experiencing this problem. My page uses lazyblocks, which load a preview in the editor. The swap option doesn't become available until the page loads fully, and if I click swap, it causes the page to become unresponsive. Making previews optional would be appreciated. |
I also experience this problem; however, the whole editor crashes, and I get this error: Error: Minified React error #185; visit https://reactjs.org/docs/error-decoder.html?invariant=185 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at al (/wp-includes/js/dist/vendor/react-dom.min.js?ver=18.2.0:10:82583)
at Jt (/wp-includes/js/dist/vendor/react-dom.min.js?ver=18.2.0:10:52962)
at $ (/wp-includes/js/dist/compose.min.js?ver=1339d3318cd44440dccb:9:24507)
at /wp-includes/js/dist/compose.min.js?ver=1339d3318cd44440dccb:9:24996
at $ (/wp-includes/js/dist/compose.min.js?ver=1339d3318cd44440dccb:9:24507)
at /wp-includes/js/dist/compose.min.js?ver=1339d3318cd44440dccb:9:24996
at Dr (/wp-includes/js/dist/vendor/react-dom.min.js?ver=18.2.0:10:72986)
at $r (/wp-includes/js/dist/vendor/react-dom.min.js?ver=18.2.0:10:75027)
at jr (/wp-includes/js/dist/vendor/react-dom.min.js?ver=18.2.0:10:74867)
at $r (/wp-includes/js/dist/vendor/react-dom.min.js?ver=18.2.0:10:75624) This seems to happen on pages with a Query block. |
I encountered this working on a client site along with the timeout for setState that crashed the editor when previewing templates on the modal in WP 6.5. Installing the gutenberg plugin resolved the issue |
Description
When trying to swap the template of a post after editing it, or when there is a lot of content already in the post, such as images for example, the page doesn't respond anymore. This doesn't happen when the content in the edited post is light.
Step-by-step reproduction instructions
In post edition
On the right click on template / swap template
Overlay window opens with a preview of the rendered page with new template.
At this point the page freezes (Chrome Version 122.0.6261.70 (Official Build) (64-bit))
Screenshots, screen recording, code snippet
No response
Environment info
Wordpress 6.4.3
Gutenberg 17.9.0
Chrome Version 122.0.6261.70 (Official Build) (64-bit))
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: