Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: success message after font install stays in other font views #59947

Closed
madhusudhand opened this issue Mar 18, 2024 · 1 comment · Fixed by #59981
Closed

Font Library: success message after font install stays in other font views #59947

madhusudhand opened this issue Mar 18, 2024 · 1 comment · Fixed by #59981
Assignees
@Mamaduka
Labels
[Feature] Font Library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@madhusudhand
Copy link
Member

Description

Success message after font installation doesn't disappear after navigating to a different font which is not installed, which is misleading in the current font context.

font-success-message

Step-by-step reproduction instructions

  1. Install a font from available font collection.
  2. Observe that success message appears after installation.
  3. navigate back and switch to another font from the list.
  4. Observe that the success message still present in the UI which is misleading in the current font context.

Screenshots, screen recording, code snippet

No response

Environment info

  • Wordpress - 6.4
  • Gutenberg - latest

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@madhusudhand madhusudhand added [Type] Bug An existing feature does not function as intended [Feature] Font Library labels Mar 18, 2024
@annezazu
Copy link
Contributor

Noting that I can replicate with 6.5 RC2. Adding this to the board to be addressed.

@annezazu annezazu moved this to 📥 Todo in WordPress 6.5 Editor Tasks Mar 18, 2024
@annezazu annezazu changed the title FontLibrary: success message after font install stays in other font views Font Library: success message after font install stays in other font views Mar 18, 2024
@Mamaduka Mamaduka mentioned this issue Mar 19, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 19, 2024
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.5 Editor Tasks Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mamaduka Mamaduka

Labels
[Feature] Font Library [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
WordPress 6.5 Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Font Library: Reset notices when navigating away from the collection WordPress/gutenberg
3 participants
@Mamaduka @madhusudhand @annezazu