Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data views grid layout: Make aspect ratio consumer configurable #60891

Open
2 tasks
jameskoster opened this issue Apr 19, 2024 · 0 comments
Open
2 tasks

Data views grid layout: Make aspect ratio consumer configurable #60891

jameskoster opened this issue Apr 19, 2024 · 0 comments
Assignees
@jorgefilipecosta
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Apr 19, 2024 •
edited
Loading

Related: #60630

Currently the preview field in grid layout renders in a hard-coded 1/1 aspect ratio, IE a square. As a default this works reasonably well, but some consumers would appreciate more expression. Pattern and Template previews for instance can be all kinds of lengths... squares don't always offer the best experience. By allowing custom (or auto to begin with) aspect ratios data views can make better use of space.

Current patterns grid with square previews

Screenshot 2024-04-19 at 10 03 38

Patterns grid with auto aspect ratio

Screenshot 2024-04-19 at 10 01 58

User preference

Down the road it might be nice to allow users to customise this display option. Such an affordance would be particularly useful in pages where the preview dimensions can vary significantly, like Media.

aspect

  • Enable data views to set aspect-ratio: auto for preview fields.
  • Add toggle so that users can swap between 1/1 and auto.
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Apr 19, 2024
This was referenced Apr 29, 2024
Merged
Merged
@jameskoster jameskoster moved this to Needs Dev in Design priorities May 30, 2024
@jameskoster jameskoster mentioned this issue Jul 4, 2024
Closed
46 tasks
@jorgefilipecosta jorgefilipecosta self-assigned this Jul 11, 2024
@jorgefilipecosta jorgefilipecosta mentioned this issue Jul 12, 2024
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 12, 2024
@jameskoster jameskoster mentioned this issue Jul 23, 2024
Closed
@youknowriad youknowriad mentioned this issue Nov 28, 2024
Open
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
Design priorities
Status: Needs Dev
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: Data views grid layout: Make aspect ratio consumer configurable. WordPress/gutenberg
2 participants
@jameskoster @jorgefilipecosta