Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views: Add 'Edit' action to editable patterns #61245

Closed
jameskoster opened this issue Apr 30, 2024 · 1 comment
Closed

Data views: Add 'Edit' action to editable patterns #61245

jameskoster opened this issue Apr 30, 2024 · 1 comment
Assignees
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

The Pages, Templates, and Template Parts data views make use of the edit post action for each item which produces the following UI:

Screenshot 2024-04-30 at 14 23 41 Screenshot 2024-04-30 at 14 23 26 Screenshot 2024-04-30 at 14 23 09

However, user generated patterns do not currently make use of this action, producing some inconsistency in the UX. Note the missing 'Edit' action in the ellipsis menu, and the missing pencil icon button:

Screenshot 2024-04-30 at 14 25 21

We can improve overall consistency by adding this action to user generated pattern data views.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Apr 30, 2024
@jorgefilipecosta jorgefilipecosta self-assigned this Jul 4, 2024
@jorgefilipecosta
Copy link
Member

Hi @jameskoster, it seems like this issue was fixed meanwhile. I'm going to close this issue as it seems working and code wise seems implemented. If things are not working on your tests feel free to reopen and I will debug what's happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants