Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared block: the Edit field is unlabelled #6199

Closed
afercia opened this issue Apr 16, 2018 · 0 comments
Closed

Shared block: the Edit field is unlabelled #6199

afercia opened this issue Apr 16, 2018 · 0 comments
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Apr 16, 2018

Any UI controls and form fields must have a properly associated label. Visible text labels are always preferable, alternatively a visually hidden <label> element or an aria-bale can be used.

Rationale:

  • all users need to clearly understand what a form field is about
  • screen reader users need to know what the form field is about when they land on it
  • speech recognition software need the label to be visible so they're able to voice a proper command "Click {field name}" to move to the field

When changing a block to a Shared block, an UI appears to give the new Shared block a name:

screen shot 2018-04-15 at 17 11 39

This field misses a label.

Strongly recommended: tests to check the presence of labels, see #6098

@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Apr 16, 2018
@afercia afercia self-assigned this Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant