Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and set a page_for_posts in the site editor #63667

Open
jameskoster opened this issue Jul 17, 2024 · 11 comments
Open

Create and set a page_for_posts in the site editor #63667

jameskoster opened this issue Jul 17, 2024 · 11 comments
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Related to #63666.

When the homepage is set to display a static page, if you want to create a page to display latest posts you must exit the site editor and configure the reading settings which is quite disruptive.

In such cases, the UI might conditionally surface an option to create a page for the blog within the site editor:

new page

If the user selects the option to create a blog, the new page is created as normal, and automatically set as page_for_posts.

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jul 17, 2024
@jameskoster jameskoster added the Needs Design Feedback Needs general design feedback. label Jul 17, 2024
@richtabor
Copy link
Member

In such cases, the UI might conditionally surface an option to create a page for the blog within the site editor:

Is this assuming you did not create a blog page when you assigned a static front page?

@jameskoster
Copy link
Contributor Author

Yes, this menu would only appear when a static homepage is set, but page_for_posts is unset. IE this configuration:

Screenshot 2024-07-22 at 12 37 02

@jasmussen
Copy link
Contributor

I wonder if this is dependant on #60772. It wouldn't really make sense without it?

@jameskoster
Copy link
Contributor Author

Not necessarily, this affordance is about allowing users to create and set page_for_posts when a static homepage is configured.

Currently to do this you need to create the page, then exit the site editor, go to reading settings and set that new page as the "Posts page"... not a particularly smooth flow! :D

This pattern can be replicated for other dynamic pages. For instance if a public post type (e.g. Products) exists we might allow users to create a "Products page" from this menu.

@jasmussen
Copy link
Contributor

I'm mostly asking because of the "Add new page" dropdown being shown in context of the pages section. Does it make sense to have this ability there, if the end result of what you create doesn't live in that section? Without that unification, "Blog page" remains a template, and could live in "Add new template" instead. I'm pro-unification, to be clear, just not sure this dropdown makes sense until such a thing has happened first.

@jameskoster
Copy link
Contributor Author

Does it make sense to have this ability there, if the end result of what you create doesn't live in that section?

That's one of the confusing pieces around the posts page UX: if you have a static homepage and a posts page, the posts page is included in the pages list. But if you don't have a static homepage and display latest posts on the homepage, then it doesn't 😓

If anything I'd say it's blocked by #63748.

@jasmussen jasmussen removed the Needs Design Feedback Needs general design feedback. label Oct 29, 2024
@jasmussen jasmussen moved this from Now to Needs Dev in Design priorities Oct 29, 2024
@mikachan
Copy link
Member

mikachan commented Dec 3, 2024

I'm planning to work on this next since the Set as Homepage action has been merged. This feels like a good next step to allow editing the homepage display reading settings from the Editor.

Let me know if this doesn't sound like the best next step, or if there's anything else that should be worked on next.

@mikachan mikachan moved this from Todo to In Progress in Automattic team Ignite's project board Dec 3, 2024
@mikachan mikachan self-assigned this Dec 5, 2024
@mikachan mikachan linked a pull request Dec 5, 2024 that will close this issue
@mikachan mikachan moved this from Needs Dev to In Dev in Design priorities Dec 5, 2024
@mikachan mikachan moved this from In Progress to Needs Review in Automattic team Ignite's project board Dec 5, 2024
@jameskoster
Copy link
Contributor Author

In the associated PR there was feedback that the design in the OP is not the right direction:

Yes, we need to make it easier / more discoverable for users to decide what they want their blog page to be. But this here is too discoverable in my opinion.
—fabiankaegy #67648 (comment)

Let's continue exploring other options.

@jameskoster
Copy link
Contributor Author

One idea could be a split button:

Image

This way adding a regular page is still a single-click exercise, but the option to create a posts page is still within reach.

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. labels Dec 9, 2024
@jasmussen
Copy link
Contributor

Yep, which can be useful for other CPTs too. Dare I even suggest post formats?

@mikachan
Copy link
Member

mikachan commented Dec 9, 2024

I like the idea of the split button. There was some feedback in #67648 that it would likely be annoying to see a dropdown on clicking this button every time a user tries to create a new page, but I think having a split button addresses this.

It also felt a little strange to immediately publish the new page after selecting a "create blog page" option, so perhaps clicking this button could take the user to the new page flow in the Editor canvas, and the page can be published or drafted manually from there. However, I think the page needs to be published in order to be successfully set as the posts page, so we'd need to handle the case where the user doesn't publish the page. Maybe by displaying a notice/modal? (This works OK for the "set as homepage" action because it's only shown on published pages.)

Dare I even suggest post formats?

🔥 This would be cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
Status: In Dev
Development

Successfully merging a pull request may close this issue.

4 participants