Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline development isn't currently possible #647

Closed
nylen opened this issue May 4, 2017 · 2 comments
Closed

Offline development isn't currently possible #647

nylen opened this issue May 4, 2017 · 2 comments
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling

Comments

@nylen
Copy link
Member

nylen commented May 4, 2017

Loading the Gutenberg editor currently blocks on several network requests for JavaScript libraries:

  • 'https://unpkg.com/react@next/umd/react' . $react_suffix . '.js'
  • 'https://unpkg.com/react-dom@next/umd/react-dom' . $react_suffix . '.js'
  • 'https://unpkg.com/react-dom@next/umd/react-dom-server' . $react_suffix . '.js'
  • 'https://fiddle.azurewebsites.net/tinymce/nightly/tinymce.min.js'

This makes it impossible to develop the plugin without an internet connection. Also, with a slow or even less-than-blazing-fast internet connection, this makes load times longer and development more difficult, especially if the "Disable cache" option is checked in the browser's dev tools.

It would be nice to come up with some other way of loading these scripts. For example:

  • Do this as part of npm run dev without holding up the rest of the build
  • Have the PHP code fetch them in development mode with caching via transients
@nylen nylen added [Type] Build Tooling Issues or PRs related to build tooling [Type] Bug An existing feature does not function as intended labels May 4, 2017
@mtias
Copy link
Member

mtias commented May 4, 2017

Related: for TinyMCE we need to see what the status of the release with link boundaries is and sync up with that once it lands in trunk WP.

@ellatrix
Copy link
Member

ellatrix commented May 5, 2017

+1 for this

Re TinyMCE: It's been released yesterday, not sure if we want to keep up with the nightly again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

No branches or pull requests

3 participants