Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders to render theme colors alongside custom colors #64734

Closed
2 tasks done
javiercasares opened this issue Aug 23, 2024 · 3 comments · Fixed by #65148
Closed
2 tasks done

Placeholders to render theme colors alongside custom colors #64734

javiercasares opened this issue Aug 23, 2024 · 3 comments · Fixed by #65148
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended

Comments

@javiercasares
Copy link

Description

Having in mind that, probably, the theme colors are “more important” than the personalized colors, when you have both, blocks only show the personalized colors by default in the block (for example, in the Cover block), although in the sidebar all colors appears correctly.

Tested in WordPress 6.6.

Step-by-step reproduction instructions

  1. Have some theme colors (not personalized colors).
  2. Add a Cover block. It shows to pick one theme color.
  3. Add some personalized colors.
  4. Add a cover block. It only shows the personalized colors in the block. In the sidebar are all the colors.

Screenshots, screen recording, code snippet

Cover only with personalized colors
Text only with personalized colors
Cover Sidebar with all the colors

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@javiercasares javiercasares added the [Type] Bug An existing feature does not function as intended label Aug 23, 2024
@ndiego
Copy link
Member

ndiego commented Aug 26, 2024

Yup, I can confirm. This behavior is a bit strange.

TT4 With Custom Colors
image
TT4 Without Custom Colors
image

@ndiego ndiego added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label Aug 26, 2024
@AKSHAT2802
Copy link
Contributor

Hii @javiercasares.
This issue seems to be connected to #64857.

I have raised a PR for the solution.PR Link.
Please reach out in case of any suggestions or feedback :)

@richtabor richtabor changed the title Theme colors vs. Personalized colors on blocks Placeholders to render theme colors with custom colors (withColorContext) Nov 7, 2024
@richtabor richtabor changed the title Placeholders to render theme colors with custom colors (withColorContext) Placeholders to render theme colors alongside custom colors (withColorContext) Nov 7, 2024
@richtabor richtabor changed the title Placeholders to render theme colors alongside custom colors (withColorContext) Placeholders to render theme colors alongside custom colors Nov 7, 2024
@richtabor
Copy link
Member

This issue seems to be connected to #64857.

Yes, this is a duplicate of #64857. Let's close this and push that one ahead as there is more discussion there.

@richtabor richtabor closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants