Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button component: Better handling of long labels #65401

Open
jameskoster opened this issue Sep 17, 2024 · 0 comments
Open

Button component: Better handling of long labels #65401

jameskoster opened this issue Sep 17, 2024 · 0 comments
Labels
Design System Issues related to the system of combining components according to best practices. Needs Design Needs design efforts. [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Extracted from #65362.

Currently the Button component used fixed height values to determine size. This can be problematic when the label is long enough to wrap:

Screenshot 2024-09-17 at 13 12 12

Guidelines should instruct consumers to avoid long labels, but sometimes it cannot be avoided e.g. translations.
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. [Package] Components /packages/components labels Sep 17, 2024
@t-hamano t-hamano mentioned this issue Sep 17, 2024
Merged
@jasmussen jasmussen added the Design System Issues related to the system of combining components according to best practices. label Sep 24, 2024
@auareyou auareyou moved this to Inbox 📥 in Design systems — Backlog Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design System Issues related to the system of combining components according to best practices. Needs Design Needs design efforts. [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
Design priorities
Status: No status
Design systems — Backlog
Status: 🔦 Needs triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jameskoster @jasmussen