Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking the template from zoom out mode asks the user to edit the template #65505

Closed
2 tasks done
andrewserong opened this issue Sep 20, 2024 · 6 comments · Fixed by #65963
Closed
2 tasks done
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@andrewserong
Copy link
Contributor

Description

While in zoom out mode while editing a page in the site editor, if you double click on the post title, it'll ask you if you want to edit the template. However, users often use the post title block in order to set the title of their page. In this case, if the user is double clicking on a post title block, can we disable zoom out, instead of displaying the template editing modal?

The assumption here is: if a user is in zoom out mode and double clicks the post title block, they are more likely to be trying to update the title of their page than they are to be wanting to edit the template.

Step-by-step reproduction instructions

  1. Open the site editor
  2. Go to Pages > any page to edit a page within the site editor
  3. Click the Zoom out button in the top bar
  4. Double click the post title block
  5. Notice that you get the modal prompt to switch to edit the template, instead of deactivating zoom out mode / allowing folks to edit the page title

Screenshots, screen recording, code snippet

2024-09-20.12.10.10.mp4

Environment info

  • Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@andrewserong andrewserong added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Zoom Out labels Sep 20, 2024
@colorful-tones colorful-tones moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.7 Editor Tasks Sep 26, 2024
@colorful-tones colorful-tones moved this from 🏗️ In Progress to 🔎 Needs Review in WordPress 6.7 Editor Tasks Sep 26, 2024
@draganescu
Copy link
Contributor

draganescu commented Sep 30, 2024

This is something that also happens when double clicking template parts in zoom out - asked about editing template but the result is you only exit the zoom out view.

@getdave
Copy link
Contributor

getdave commented Oct 7, 2024

A solution here seem like it would be to have the double click hander on the "Edit template" also exit Zoom Out mode if it's active.

@getdave
Copy link
Contributor

getdave commented Oct 7, 2024

Doubling clicking a template should exit Zoom Out and not activate the Template Editor. You should not be able to "activate" the Template Editor from Zoom Out.

@richtabor
Copy link
Member

Doubling clicking a template should exit Zoom Out and not activate the Template Editor. You should not be able to "activate" the Template Editor from Zoom Out.

Yes, exactly.

@andrewserong
Copy link
Contributor Author

Nice, that sounds like a simple way to resolve this 👍

@andrewserong
Copy link
Contributor Author

I've tried that idea out over in #65963. Happy for any feedback!

@richtabor richtabor changed the title Zoom out mode: Double clicking the post title block from zoom out mode asks the user to edit the template Double clicking the template from zoom out mode asks the user to edit the template Oct 9, 2024
@ndiego ndiego moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.7 Editor Tasks Oct 9, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.7 Editor Tasks Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Status: Done
4 participants