-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flaky Test] Entering zoomed out mode zooms the canvas #66051
Labels
[Type] Flaky Test
Auto-generated flaky test report issue
Comments
github-actions
bot
added
the
[Type] Flaky Test
Auto-generated flaky test report issue
label
Oct 11, 2024
github-actions bot
referenced
this issue
Oct 11, 2024
* Update preact packages * Update package-lock * Fix some EffectFn types * Remove outdated ts-expect-error * Add changelog Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: cbravobernal <[email protected]>
This was referenced Oct 11, 2024
@talldan it didn't make it long... EDIT: I'm thinking, let's not check for the specific transform values, just make sure that the width and height of the canvas are smaller than the iframe. I'm not sure if that's enough to stabilize it |
github-actions bot
referenced
this issue
Oct 11, 2024
#66060) Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: sgomes <[email protected]>
I don't think it's the transform one that's failing, this is the error I'm seeing:
I wonder how it ended up with |
github-actions bot
referenced
this issue
Oct 14, 2024
Co-authored-by: jasmussen <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: kevin940726 <[email protected]>
This was referenced Oct 14, 2024
github-actions bot
referenced
this issue
Oct 15, 2024
* Remove bindings bootstrap functions * Remove bootstrap calls * Remove old filter * Adapt unit tests * Add compat filter in Gutenberg * Only run script if not already registered * Remove extra label in test * Remove unit test * Add backport changelog * Return warning if any client-only prop is defined Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: ryanwelcher <[email protected]>
github-actions bot
referenced
this issue
Oct 15, 2024
Co-authored-by: akasunil <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
github-actions bot
referenced
this issue
Oct 15, 2024
* Positions the iframed HTML canvas via translateX rather than margin-left on the iframe in order to have the scrollbar for the iframe available instead of hidden off canvas. This also fixes issues with the vertical toolbar and inserters not rerendering to their new positions. * Renames prevContainerWidthRef to initialContainerWidth so it's clearer that this is the point when zoom out was initialized, then renames the CSS vars prev-container-width to outer-container-width, using the larger value of containerWidth or initialContainerWidth so it can be more consistently named. * Force largest available window size to scale from If you started with a sidebar open, then entered zoom out, then closed the sidebar, your scaled canvas would be too large. It should match the same size as if you start with no sidebars open, then enter zoom out. This also fixes an issue where scaling could be larger than 1. * Only animate scaling on entry and exit of zoom out mode to improve animations when opening and closing sidebars. * Known divergence: When starting from a smaller canvas (sidebars open), entering zoom out, then closing sidebars, there will be reflow on the canvas. --------- Co-authored-by: jeryj <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: MaggieCabrera <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: dhruvang21 <[email protected]> Co-authored-by: AhmarZaidi <[email protected]> Co-authored-by: kevin940726 <[email protected]>
github-actions bot
referenced
this issue
Oct 15, 2024
Co-authored-by: ajlende <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: mrfoxtalbot <[email protected]> Co-authored-by: jordesign <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: iamtakashi <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: henriqueiamarino <[email protected]>
github-actions bot
referenced
this issue
Oct 15, 2024
- Add missing `post.slug` dependency to `useMemo` Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: youknowriad <[email protected]>
This was referenced Oct 15, 2024
github-actions bot
referenced
this issue
Oct 16, 2024
Co-authored-by: tyxla <[email protected]> Co-authored-by: Mamaduka <[email protected]>
This was referenced Oct 16, 2024
github-actions bot
referenced
this issue
Oct 16, 2024
Co-authored-by: michalczaplinski <[email protected]> Co-authored-by: cbravobernal <[email protected]>
github-actions bot
referenced
this issue
Oct 16, 2024
Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]>
github-actions bot
referenced
this issue
Oct 16, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: kevin940726 <[email protected]>
github-actions bot
referenced
this issue
Oct 16, 2024
Co-authored-by: jeryj <[email protected]> Co-authored-by: ajlende <[email protected]>
This was referenced Oct 16, 2024
Merged
github-actions bot
referenced
this issue
Oct 17, 2024
Co-authored-by: renatho <[email protected]> Co-authored-by: kevin940726 <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: andrewserong <[email protected]>
This was referenced Oct 17, 2024
github-actions bot
referenced
this issue
Oct 17, 2024
Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: t-hamano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.
Test title
Entering zoomed out mode zooms the canvas
Test path
/test/e2e/specs/site-editor/zoom-out.spec.js
Errors
[2024-10-11T09:32:47.098Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-11T10:48:08.504Z]
Test passed after 1 failed attempt onfix/device-type-browse-styles
.[2024-10-11T12:18:46.815Z]
Test passed after 1 failed attempt onfix/posturl-ui-slug-peermalink
.[2024-10-11T13:40:23.186Z]
Test passed after 2 failed attempts onupdate/grid-visualizer-to-be-hidden-in-zoom-out-mode
.[2024-10-11T15:10:49.158Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-14T05:27:31.691Z]
Test passed after 2 failed attempts onfix/e2e-storybook-config
.[2024-10-14T07:05:20.980Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-14T08:54:34.294Z]
Test passed after 1 failed attempt onfix/bootstrap-server-sources-earlier
.[2024-10-14T08:55:58.472Z]
Test passed after 1 failed attempt onfix/posturl-ui-slug-peermalink
.[2024-10-14T20:54:38.670Z]
Test passed after 1 failed attempt ondocs/block-editor
.[2024-10-15T04:58:35.661Z]
Test passed after 1 failed attempt ontry/custom-presets-ignore-duplicate-slugs
.[2024-10-15T08:23:52.478Z]
Test passed after 1 failed attempt onrefactor-pattern-inserter
.[2024-10-15T09:33:37.654Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-15T11:27:20.338Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-15T13:50:09.759Z]
Test passed after 1 failed attempt onfix/iframe-zoom-container
.[2024-10-15T14:38:27.885Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-15T14:45:32.057Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-15T15:22:42.097Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-15T17:03:07.960Z]
Test passed after 1 failed attempt onupdate/several-typos
.[2024-10-16T00:32:17.987Z]
Test passed after 1 failed attempt onfix/toggle-group-control-focus
.[2024-10-16T06:08:32.239Z]
Test passed after 2 failed attempts ontrunk
.[2024-10-16T09:31:21.120Z]
Test passed after 1 failed attempt onfix/use-get-entity-config-instead-of-get-post-types
.[2024-10-16T09:41:32.168Z]
Test passed after 1 failed attempt onfix/update-changelog-fsn
.[2024-10-16T09:58:56.868Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-16T10:12:47.166Z]
Test passed after 1 failed attempt onfix/allow-label-override-in-bindings-registration
.[2024-10-16T10:49:27.670Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-16T11:50:16.614Z]
Test passed after 1 failed attempt onfix/use-get-entity-config-instead-of-get-post-types
.[2024-10-16T14:33:17.379Z]
Test passed after 1 failed attempt onupdate/alphabetize-styles
.[2024-10-16T17:08:26.124Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-16T17:56:48.315Z]
Test passed after 1 failed attempt onmanaging-packages
.[2024-10-16T18:05:13.877Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-16T18:40:38.728Z]
Test passed after 1 failed attempt onadd/storybook-elevation-tokens
.[2024-10-16T19:02:12.936Z]
Test passed after 2 failed attempts onfix/html-scale-code-quality
.[2024-10-16T19:37:18.814Z]
Test passed after 2 failed attempts onfix/iapi-deep-merge-undefined-objects-reactivity
.[2024-10-17T02:49:25.547Z]
Test passed after 1 failed attempt onfix/type-use-select-param
.[2024-10-17T03:54:52.097Z]
Test passed after 1 failed attempt ontrunk
.[2024-10-17T09:21:39.639Z]
Test passed after 1 failed attempt oncolor-palette/background-overflow
.[2024-10-17T10:05:08.544Z]
Test passed after 1 failed attempt onupdate/scripts-check-licenses-extract-logic
.[2024-10-17T11:03:07.657Z]
Test passed after 1 failed attempt onfix/tabs-rtl
.[2024-10-17T13:37:13.444Z]
Test passed after 1 failed attempt onupdate/shuffle-patterns-to-update-design
.[2024-10-17T14:12:42.310Z]
Test passed after 1 failed attempt onrefactor/tablist-styled
.[2024-10-17T14:17:52.797Z]
Test passed after 2 failed attempts onfix/tabs-tablist-tabindex
.[2024-10-17T14:41:59.550Z]
Test passed after 1 failed attempt onstorybook-nav-utilities
.[2024-10-17T15:46:30.294Z]
Test passed after 1 failed attempt ontrunk
.The text was updated successfully, but these errors were encountered: