Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom out persists after reloads but not entirely engaged #66138

Closed
2 tasks done
stokesman opened this issue Oct 15, 2024 · 2 comments · Fixed by #66141
Closed
2 tasks done

Zoom out persists after reloads but not entirely engaged #66138

stokesman opened this issue Oct 15, 2024 · 2 comments · Fixed by #66141
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended

Comments

@stokesman
Copy link
Contributor

Description

If the page is reloaded while zoom out is engaged the mode is engaged upon reload yet the toolbar button is not shown as pressed and the view scaling/frame spacing is not present.

I'm not sure when/how this came about or if it was intentional.

Step-by-step reproduction instructions

  1. Engage zoom out
  2. Reload the page
  3. Note that zoom out is still engaged (select a block and note the inserter buttons)

Screenshots, screen recording, code snippet

zoom-out-persisting-after-refresh.mp4

Environment info

Gutenberg trunk

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@stokesman stokesman added [Feature] Zoom Out [Type] Bug An existing feature does not function as intended labels Oct 15, 2024
@jasmussen
Copy link
Contributor

Encountered this as well, this is an important one to fix.

@talldan
Copy link
Contributor

talldan commented Oct 17, 2024

From my testing, this doesn't happen in the wp/6.7 branch, so I'm removing it from the WordPress 6.7 Editor Tasks board.

I believe #65945 introduced the persistence of the modes, and it wasn't backported for 6.7.

A fix will still be needed for trunk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants