Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the verb Toggle from the data views 'Toggle details panel' #66319

Closed
2 tasks done
afercia opened this issue Oct 22, 2024 · 2 comments · Fixed by #66334
Closed
2 tasks done

Remove the verb Toggle from the data views 'Toggle details panel' #66319

afercia opened this issue Oct 22, 2024 · 2 comments · Fixed by #66334
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Good First Issue An issue that's suitable for someone looking to contribute for the first time l10n Localization and translations best practices [Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Oct 22, 2024

Description

Similarly to #65983

The verb 'toggle' isn't well translatable in many languages and should not be used. See #42492 and similar trac ticket for Core.

Image

Step-by-step reproduction instructions

  • Go to the Site editor > Pages
  • Switch the data views to Table or Grid layout
  • Observe the 'Toggle details panel' button in the top bar

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@afercia afercia added [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Package] Edit Site /packages/edit-site [Type] Bug An existing feature does not function as intended l10n Localization and translations best practices labels Oct 22, 2024
@t-hamano t-hamano added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 22, 2024
@AhmarZaidi AhmarZaidi mentioned this issue Oct 22, 2024
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 22, 2024
@AhmarZaidi
Copy link
Contributor

Here's the PR for this issue: #66334

Also, I noticed that 'toggle' appears in some other places as well.
Here's a list:

gutenberg/packages/block-editor/src/components/block-full-height-alignment-control/index.js

Line 10 in 80fcf02

label = __( 'Toggle full height' ),

gutenberg/packages/block-library/src/search/edit.js

Line 378 in 80fcf02

title={ __( 'Toggle search label' ) }

gutenberg/packages/edit-post/src/components/keyboard-shortcuts/index.js

Line 25 in 80fcf02

description: __( 'Toggle fullscreen mode.' ),

gutenberg/packages/editor/src/components/commands/index.js

Line 120 in 80fcf02

label: __( 'Toggle spotlight' ),

gutenberg/packages/editor/src/components/commands/index.js

Line 163 in 80fcf02

label: __( 'Toggle top toolbar' ),

gutenberg/packages/editor/src/components/commands/index.js

Line 227 in 80fcf02

label: __( 'Toggle settings sidebar' ),

gutenberg/packages/editor/src/components/commands/index.js

Line 242 in 80fcf02

label: __( 'Toggle block inspector' ),

gutenberg/packages/editor/src/components/global-keyboard-shortcuts/register-shortcuts.js

Line 85 in 80fcf02

description: __( 'Toggle distraction free mode.' ),

@afercia
Copy link
Contributor Author

afercia commented Oct 23, 2024

I noticed that 'toggle' appears in some other places as well.

Thanks @AhmarZaidi yes, there's a few more than those. I'll create a new issue. Time to get rid of all occurrences of the verb toggle.

This was referenced Oct 23, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond Good First Issue An issue that's suitable for someone looking to contribute for the first time l10n Localization and translations best practices [Package] Edit Site /packages/edit-site [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove toggle verb from post list data views 'Toggle details panel' AhmarZaidi/wp-gutenberg
3 participants
@afercia @t-hamano @AhmarZaidi