Zoom out returns after inserter is closed

[draganescu]

Description

Disabling zoom out while the inserter is open makes it come back when the inserter is closed.

Step-by-step reproduction instructions

the-return-of-the-zoom-out.mp4

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[draganescu]

This is because of the useZoomOut hook "toggling" the state instead of setting it.

[Mamaduka]

I also noticed that the useZoomOut hook is public and shipped with WP 6.6. It should've been a private hook.

[jeryj]

I also noticed that the useZoomOut hook is public and shipped with WP 6.6. It should've been a private hook.

Yup -- that is true.

@draganescu - @ajlende and I are testing this and unable to reproduce on the 6.7 branch. Can you try again on 6.7?

[jeryj]

Confirmed this a bug on trunk, not on wp/6.7. I remove it from the wp/6.7 board and removed the high priority tag.

[Mamaduka]

There might still be time to make useZoomOut private and remove public references. I doubt anyone is using this hook outside of the plugin/core.

[draganescu]

I triple vote this. Then maybe we can delete it.

[jeryj]

Made it private in this PR: #66374

[Mamaduka]

Encountered and got reminded of this bug again today. Here's my alternative approach - #67033.