Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to manually define an aria-label for the navigation block #66935

Closed
fabiankaegy opened this issue Nov 12, 2024 · 1 comment · Fixed by #66943
Closed

Add the ability to manually define an aria-label for the navigation block #66935

fabiankaegy opened this issue Nov 12, 2024 · 1 comment · Fixed by #66943
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@fabiankaegy
Copy link
Member

The core navigation block uses the name of the Navigation post that is assigned to it as it's aria label.

This behavior is not documented/called out anywhere.

Since the name of a navigation menu in the admin isn't necessarily very prescriptive to a user using a screen reader on the front end of the site, it would be great to be able to decouple this aria-label from the title of the navigation post.

We should still leave that behavior as the default/fallback in case no label gets specified manually. However, having the ability to define a custom label via the advanced settings panel would be a great improvement.

This way that actual label could already get defined in code rather than relying on the user to set it correctly.

@fabiankaegy fabiankaegy added [Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement. labels Nov 12, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 12, 2024
@up1512001
Copy link
Member

@fabiankaegy raised PR to address this, can you please review 🙇‍♂
#66943

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants