Conflict between Zoom Out mode and Distraction free mode

[t-hamano]

Description

It is possible to have Zoom Out mode and Distraction free mode enabled at the same time via the zoom out toggle button or shortcuts.

Zoom out mode expects to insert patterns at the root level via the inserter, whereas Distraction free mode does not expect to insert blocks, resulting in a conflict.

Step-by-step reproduction instructions

• Enable Distraction free mode.
• Click the Zoom out toggle button.

Screenshots, screen recording, code snippet

a5e9a358ad7d326681fb591920a23a6e.mp4

Environment info

No response

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[yogeshbhutkar]

Thanks, @t-hamano for the issue.

Can you please describe the ideal behavior in this case? Do we allow inserter access when distraction mode is enabled and the content is zoomed out?

[t-hamano]

For now, I haven't come up with an ideal behavior. We also need to consider whether to allow both Zoom Out mode and Distraction free mode to be enabled.

[yogeshbhutkar]

@t-hamano, I think the ideal behavior should be to allow zooming out, but when the Distraction Free mode is enabled, then, when zoomed out, the Inserter Mode Button should ideally be disabled or should be made hidden.

[t-hamano]

I think the ideal behavior should be to allow zooming out, but when the Distraction Free mode is enabled, then, when zoomed out, the Inserter Mode Button should ideally be disabled or should be made hidden.

In this case, we can't do anything in Zoom Out mode, right? I think the main purpose of Zoom Out mode is to be able to insert patterns at the root level.

[yogeshbhutkar]

@t-hamano Agreed!!!

Probably the feature ( zoom out ) can be used to view the content at a glance as well. Seems like a basic feature to have even after eliminating its association with the inserter, this can independently be used.

These two features conflict for sure, but I think limiting the Inserter of Zoomed Out state is the most efficient way to tackle the problem instead of either keeping Zoom out in its entirety or removing it completely when distraction-free mode is enabled.

I've raised a PR, the preview is attached as a screencast on the PR itself, will modify based on the flow of discussion that happens here.

Thank You.

[Mamaduka]

We should probably hide/disable the Zoom out toggle when in distraction-free mode. We do the same thing for Inserter, List View, Preview and others.

cc @richtabor, @draganescu

[yogeshbhutkar]

@t-hamano @Mamaduka, I've updated the PR accordingly with the expected behavior.

Thanks for your suggestions.

[draganescu]

I agree we should not show the zoom out control in DFM because the zoom out feature - for now at least - makes sense with the UI of the editor nearby to allow for quick building an iteration of high level content structure.