Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor should display a 404 message when you navigate to a non-existing path #67445

Open
3 of 6 tasks
carolinan opened this issue Nov 30, 2024 · 4 comments
Open
3 of 6 tasks
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

Description

With a block theme and Gutenberg trunk active, if you open the Site Editor but miss-type the link, the Site Editor is now a black page with no message or content showing.

Without Gutenberg active, you are presented with the index template (Or home blog or front page, if the theme uses that)

Step-by-step reproduction instructions

Try navigating to wp-admin/site-editor.php?p=%2Ftemplate-fdgfdgdfg.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@carolinan carolinan added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended labels Nov 30, 2024
@carolinan
Copy link
Contributor Author

@youknowriad I believe this is related to #67199.

@youknowriad
Copy link
Contributor

Yes, we discussed this in the PR. We should define a real 404 page instead of showing the home page like before.

@carolinan

This comment has been minimized.

@youknowriad

This comment has been minimized.

@carolinan carolinan changed the title Site Editor should display the correct context when you navigate to a non-existing path Site Editor should display a 404 message when you navigate to a non-existing path Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants