Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template parts: use "Change design" drop down instead of Design panel #67451

Open
ramonjd opened this issue Dec 1, 2024 · 6 comments
Open

Template parts: use "Change design" drop down instead of Design panel #67451

ramonjd opened this issue Dec 1, 2024 · 6 comments
Assignees
Labels
[Block] Template Part Affects the Template Parts Block [Type] Enhancement A suggestion for improvement.

Comments

@ramonjd
Copy link
Member

ramonjd commented Dec 1, 2024

What problem does this address?

To make designs available always (in Write mode especially), let's relocate the sidebar “design” panel for template parts to the block toolbar, similar to the Query block.

Follow up to: #66993

Current location of design patterns for template parts

Image

The "Change design" button for the query block

Image

What is your proposed solution?

Look for a way to make this control "generic", for example, as part of a hook in the block editor package.

Then it could be extracted from the Query block code, moved to a central location, and applied to both the query and template part blocks.

See this comment:

#66993 (comment)

@ramonjd ramonjd added [Block] Template Part Affects the Template Parts Block [Type] Enhancement A suggestion for improvement. labels Dec 1, 2024
@ramonjd ramonjd self-assigned this Dec 1, 2024
@carolinan

This comment has been minimized.

@ramonjd

This comment has been minimized.

@carolinan

This comment has been minimized.

@richtabor
Copy link
Member

The "Change design" button for the query block

@ramon Another follow up, for the query block though, would be to use the same styles for the popover as "Change design" does from zoom out. The current popover is pretty rough as-is.

Image

@ramonjd
Copy link
Member Author

ramonjd commented Dec 3, 2024

Thanks for the feedback @richtabor I'll take a look when I next get a chance.

@ramonjd
Copy link
Member Author

ramonjd commented Dec 4, 2024

use the same styles for the popover as "Change design" does from zoom out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants