Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding Redux state selectors #693

Closed
nylen opened this issue May 5, 2017 · 0 comments · Fixed by #720
Closed

Consider adding Redux state selectors #693

nylen opened this issue May 5, 2017 · 0 comments · Fixed by #720
Assignees
@youknowriad
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Question Questions about the design or development of the editor.

Comments

@nylen
Copy link
Member

nylen commented May 5, 2017 •
edited
Loading

As our state tree and the things we need to do with it become more complicated, we are starting to repeat ourselves a bit in the connect calls, and this will probably continue. Also there is a good bit of testable logic starting to show up there. See #594 for a couple of examples.

To avoid repetition and make this code easier to test, we should consider adding something like Calypso's state selectors.
@nylen nylen added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Question Questions about the design or development of the editor. labels May 5, 2017
@youknowriad youknowriad self-assigned this May 9, 2017
@youknowriad youknowriad mentioned this issue May 9, 2017
Merged
@nylen nylen closed this as completed in #720 May 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Question Questions about the design or development of the editor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

State: Extract selectors to a global selectors file WordPress/gutenberg
2 participants
@nylen @youknowriad