Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tips: status should be user-based not browser-based #8052

Closed
folletto opened this issue Jul 19, 2018 · 4 comments
Closed

Tips: status should be user-based not browser-based #8052

folletto opened this issue Jul 19, 2018 · 4 comments
Labels
[Feature] NUX Anything that impacts the new user experience Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@folletto
Copy link
Contributor

screen shot 2018-07-19 at 14 46 29

While reviewing tips I was informed that to try a new one I had to clear my local data (related: #8051 about triggering it via URL). Which seems pointing out that the flags to trigger tips are local to the browser.

However, it doesn't make sense that a specific user have to get new tips every time they switch browser or device or profile. These kinds of informations are designed to be provided to each person once, and as such they shouldn't be repeated (unless requested by the user).

Suggestion:

  • Store the tips "dismissed" status per-user
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] NUX Anything that impacts the new user experience labels Jul 19, 2018
@afercia
Copy link
Contributor

afercia commented Jul 26, 2018

As far as I know, technically it's already stored on a per-user basis, but just in the browser's local storage :) It should be saved in the DB.

Worth noting many other preferences are stored just in the browser, for example:

  • sidebar state
  • sidebar panels toggled state
  • fixed toolbar
  • editor mode
  • plugins pinned items
  • etc.

That means the same user will see different UI settings when logging in with a different browser. So I guess the actual issue is a bit broader... 😉

@JJJ
Copy link
Contributor

JJJ commented Oct 18, 2018

That means the same user will see different UI settings when logging in with a different browser. So I guess the actual issue is a bit broader

I agree. I expect all of those preferences to follow my account around, not my browser. These should be persistent to me, not the window I'm looking at at the time.

@aduth
Copy link
Member

aduth commented Feb 27, 2020

Thanks for the report. While I had created it after this one, the issue at #15105 contains the actionable technical implementation related to this task. I will close this to consolidate discussion.

See also: #19177

@aduth
Copy link
Member

aduth commented Feb 27, 2020

Duplicate of #15105

@aduth aduth marked this as a duplicate of #15105 Feb 27, 2020
@aduth aduth closed this as completed Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] NUX Anything that impacts the new user experience Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants