Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio and Video blocks: the URL input field is unlabelled #8104

Closed
afercia opened this issue Jul 21, 2018 · 1 comment
Closed

Audio and Video blocks: the URL input field is unlabelled #8104

afercia opened this issue Jul 21, 2018 · 1 comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Jul 21, 2018

In the Audio and Video blocks, the "Enter URL" input fields are unlabelled. All input fields need to be properly labelled to communicate users what they're about.

Since the start of the project there have been several cases where unlabelled controls have landed in the codebase. Once again, I'd like to strongly recommended: automated tests to check the presence of labels, see #6098

Worth also reminding placeholders are not replacement for labels.
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Jul 21, 2018
This was referenced Jul 21, 2018
Closed
Merged
@afercia
Copy link
Contributor Author

afercia commented Jul 24, 2018

Fixed in #8105

@afercia afercia closed this as completed Jul 24, 2018
@afercia afercia mentioned this issue Sep 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afercia