Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: Paragraph #8194

Closed
3 of 6 tasks
sarahmonster opened this issue Jul 25, 2018 · 5 comments
Closed
3 of 6 tasks

Block audit: Paragraph #8194

sarahmonster opened this issue Jul 25, 2018 · 5 comments
Assignees
Labels
[Block] Paragraph Affects the Paragraph Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Jul 25, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress.

Overview

Name: Paragraph
Icon:
screenshot 2018-07-25 11 50 33
Description: Add some basic text
Category: Common blocks
CSS class: None normally, uses .has-drop-cap when it has a drop cap
Can be converted to: Heading, list, quote, preformatted, subheading, verse

Empty/placeholder state

This block shows just a prompt as a placeholder, to facilitate "just start writing":

screenshot 2018-07-25 13 09 28

These are placeholders/hints for Gutenberg as a whole that sort of relate to the paragraph block, since it's the default:

screenshot 2018-07-25 13 09 17

screenshot 2018-07-25 13 10 29

Primary (toolbar) settings

Alignment, bold, italic, strikethrough, link

Secondary (sidebar) settings

Text settings: custom size, drop cap.
Background color
Text color

Frontend appearance

Gutenberg starter theme:
screenshot 2018-07-25 12 50 35
screenshot 2018-07-25 12 50 49

twentyseventeen:
screenshot 2018-07-25 12 52 16

twentyten:
screenshot 2018-07-25 12 54 52

Documentation

No devdocs in https://github.com/WordPress/gutenberg/tree/master/core-blocks/paragraph

Suggestion for user-facing docs:

Performance on mobile

Accessibility

Bugs/errors

  • Text settings is a vague heading for the first group of settings. Drop cap looks like it's really tightly spaced into the custom size, mostly because of the toggle placement, which makes it hard to visually discern the options. Recommend instead making Drop cap its own section here.

  • There are three different controls here for text size: S|M|L|XL, a slider, and a numerical input. I'm guessing the input is for accessibility purposes. What about nixing either the slider or the S|M|L options?

  • Floating drop cap is problematic. (Paragraph block: Floating drop-cap is problematic #8447)

  • Disappearing drop cap is also problematic. (Disappearing drop cap causes jumpy behaviour #11119)

  • When linking a bit of text, the text being linked loses its highlight. (Insert link: the link selection disappears when entering a link #6156)

  • "This color combination may be hard for people to read...." notice appears after setting the background colour under the text colour heading.

@danielbachhuber danielbachhuber added the [Feature] Blocks Overall functionality of blocks label Jul 25, 2018
@ZebulanStanphill
Copy link
Member

Image appears because it has a keyword defined containing "p"... probably "picture".

I think there was a change at some point to make the current block not show up in the slash inserter, since it would be redundant. It might just be hardcoded to the Paragraph block, though, which would not be a good thing.

I think it is weird that the Paragraph block has text color settings, yet the Heading and List blocks do not. These 3 are usually used together in the context of page building, and because of that I think that all 3 blocks should have text color and background color settings, or else none of them should have color settings. I would prefer the former. I would say that the Verse block should also have text color options, but I do not feel as strongly about that one. See also: #8171.

@designsimply designsimply added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jul 25, 2018
@paulwilde
Copy link
Contributor

This doesn't appear in the slash inserter—should it?

The inserter already is the paragraph block, so it wouldn't makes sense to convert it into itself.

@sarahmonster sarahmonster self-assigned this Jul 26, 2018
@bph
Copy link
Contributor

bph commented Aug 23, 2018

When I have a paragraph with a blue background the highlighting is invisible, when you want to replace a string...
http://recordit.co/lE7Nvtt2r5

@ZebulanStanphill
Copy link
Member

@bph I made an issue for that: #7967.

@sarahmonster sarahmonster added the [Block] Paragraph Affects the Paragraph Block label Oct 26, 2018
@sarahmonster
Copy link
Member Author

All issues here have been filed as individual issues, so I'm going to go ahead and close out this tracking bug. Feel free to comment on if I missed anything, or open new issues as needed! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paragraph Affects the Paragraph Block [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

6 participants