Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: Audio #8297

Closed
3 of 8 tasks
sarahmonster opened this issue Jul 30, 2018 · 3 comments
Closed
3 of 8 tasks

Block audit: Audio #8297

sarahmonster opened this issue Jul 30, 2018 · 3 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Jul 30, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screenshot 2018-07-30 15 16 49

Name: Audio
Description: Embed an audio file and a simple audio player.
Category: Common blocks
CSS class: wp-block-audio in frontend or editor
Can be converted to: file

States

Empty:
screenshot 2018-07-30 15 04 01

Selected:
screenshot 2018-07-30 15 07 47

With a caption:
screenshot 2018-07-30 15 22 21

With a caption and right-aligned:
screenshot 2018-07-30 15 07 47

Unselected:
screenshot 2018-07-30 15 22 27
screenshot 2018-07-30 15 22 37

Placeholder:
screenshot 2018-07-30 15 04 45

Primary (toolbar) settings

Align: left, centre, right, edit
For captions: bold, italic, strikethrough, link

Secondary (sidebar) settings

Audio Settings: Autoplay, Loop, Preload
Advanced: Additional CSS Class

Frontend appearance

Gutenberg starter theme:

screen shot 2018-07-31 at 1 57 53 pm

Atomic Blocks

screen shot 2018-07-31 at 1 53 20 pm

twentyseventeen:

screen shot 2018-07-31 at 2 29 09 pm

twentyten:

screen shot 2018-07-31 at 2 28 08 pm

Bugs/errors

Individual issues will be opened for these soon

Suggestions

Individual issues will be opened for these soon

@sarahmonster sarahmonster self-assigned this Jul 30, 2018
@sarahmonster sarahmonster added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Jul 30, 2018
@n2questdev
Copy link

How to prohibit download option? I don't want users to download my audio files. Please suggest..

@kjellr
Copy link
Contributor

kjellr commented Jan 28, 2019

All of the bugs/errors noted here have been filed as individual issues.

I'm not going to open an individual issue for that last suggestion at this point, but it's recorded here for reference. If we want to pursue in the future, we can open a new issue.

Closing this in the meantime. 👍

@carolynrosner
Copy link

Like ajuluri above, I'd like to see a way to disable audio file downloading by hiding the control at far right. I tried to do it with CSS but there is no way to target that one behavior. I have not found a plugin that does the job either. Please consider reopening this issue. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

4 participants