Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash inserter: enable searching blocks with more than one string match #8365

Closed
ShinichiNishikawa opened this issue Aug 1, 2018 · 3 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.

Comments

@ShinichiNishikawa
Copy link

Is your feature request related to a problem? Please describe.

When searching, for example, image block in Japanese /image doesn't work but instead you need to change your typing language to Japanese and type /画像. This isn't a pleasant experience because I need to first set the typing language to English to get /, and then switch to Japanese to type 画像. It would be much better if I can get the image block both with /image and /画像.

If this issue is solved, it will give more possibilities.
We can get Twitter oEmbed block by typing /sns, /tweet, and /ツイッター in addition to /twitter.

Describe the solution you'd like

It would be nice if we can register multiple search keywords for each block.

@designsimply designsimply changed the title Enable searching blocks with more than one string match. Slash inserter: enable searching blocks with more than one string match Aug 1, 2018
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Aug 1, 2018
@chrisvanpatten
Copy link
Contributor

chrisvanpatten commented Aug 2, 2018

So it is possible to pass multiple keywords in for a block that are triggered in the inserter (for example you can type “h2” to find the heading block).

So I expect here the issue is actually allowing translators to provide additional, language-specific options for a block’s keywords. This would be useful as in the case in the issue report (languages with non-Roman characters that might require changing between different text input methods, and trying to improve that case) or perhaps if there are any languages that might have multiple words to refer to a concept that only has one word in English.

Admittedly I’m not super well-versed in WordPress’ translation APIs but off the top of my head I’m not aware of any comparable analogues in core that could be used as a model here.

@mcsf
Copy link
Contributor

mcsf commented Aug 21, 2018

I left a comment on #6633 that uses @ShinichiNishikawa 's case as illustration. If the proposal seems like a good start, I propose closing this issue in favor of #6633.

@mcsf mcsf added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Aug 21, 2018
@mcsf
Copy link
Contributor

mcsf commented Aug 24, 2018

Closing in favor of #6633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants