Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File block: Outputs an unencoded line break on frontend #8402

Closed
sarahmonster opened this issue Aug 2, 2018 · 1 comment
Closed

File block: Outputs an unencoded line break on frontend #8402

sarahmonster opened this issue Aug 2, 2018 · 1 comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@sarahmonster
Copy link
Member

The file block looks like this in the editor:

screenshot 2018-08-02 18 43 23

But when I preview the post in my theme, I'm seeing an unencoded line break. This, in turn, mucks up some of the post that follows it:

screenshot 2018-08-02 18 36 18

This seems to have been recently introduced, and/or it only happens when you edit the filename text.

Unedited text 👌

screenshot 2018-08-02 18 45 56

Edited text 😱

screenshot 2018-08-02 18 46 17

Steps to reproduce:

  1. Insert a new file block.
  2. Upload a file.
  3. Edit the filename text string in the editor.
  4. Preview the post.
  5. Line breaks ensue.
@sarahmonster sarahmonster added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Aug 2, 2018
@sarahmonster sarahmonster mentioned this issue Aug 2, 2018
7 tasks
@mtias mtias added this to the WordPress 5.0 milestone Oct 27, 2018
@jorgefilipecosta
Copy link
Member

Hi @sarahmonster thank you for reporting this issue. I'm not being able to replicate this problem. File block was changed to use RichText and I think as a side effect this bug got solved. If you are still able to reproduce this problem feel free to reopen the issue and I will look again into this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants